Merge pull request #110 from stainless-api/sam/200-no-204

fix: return 200 instead of 204 for empty responses

Author: dgellow

packages/hono/src/__tests__/honoPlugin.test.ts

@@ -31,19 +31,19 @@ describe("void-returning handlers", () => {
   const app = new Hono();
   app.use("*", stlApi(api));
 
-  test("handler returning void responds with 204", async () => {
+  test("handler returning void responds with 200", async () => {
     const response = await app.request("/api/webhooks/events", {
       method: "POST",
     });
-    expect(response.status).toBe(204);
+    expect(response.status).toBe(200);
     expect(await response.text()).toBe("");
   });
 
-  test("handler with explicit bare return responds with 204", async () => {
+  test("handler with explicit bare return responds with 200", async () => {
     const response = await app.request("/api/webhooks/noop", {
       method: "POST",
     });
-    expect(response.status).toBe(204);
+    expect(response.status).toBe(200);
     expect(await response.text()).toBe("");
   });
 });

packages/hono/src/honoPlugin.ts

@@ -92,7 +92,7 @@ function makeHandler(endpoints: AnyEndpoint[], options?: StlAppOptions) {
       }
 
       if (result === undefined) {
-        return c.body(null, 204);
+        return c.body(null, 200);
       }
 
       return c.json(result);