Merge pull request #1379 from kolyshkin/v1-fix-ci

[v1] fix CI, add Go 1.17.x and 1.18.x

Author: meatballhat

.github/workflows/cli.yml

@@ -15,13 +15,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macos-latest]
-        go:
-          - 1.16.x
-          # NOTE: tests fail with panic at
-          # TestApp_RunAsSubCommandIncorrectUsage on these
-          # versions:
-          # - 1.17.x
-          # - 1.18.x
+        go: [1.16.x, 1.17.x, 1.18.x]
     name: ${{ matrix.os }} @ Go ${{ matrix.go }}
     runs-on: ${{ matrix.os }}
     steps:
@@ -38,6 +32,6 @@ jobs:
 
       - name: Run Tests
         run:
-          go run build.go vet &&
-          go run build.go test &&
+          go run build.go vet
+          go run build.go test
           go run build.go toc docs/v1/manual.md

app_test.go

@@ -508,6 +508,14 @@ func TestApp_RunAsSubcommandParseFlags(t *testing.T) {
 }
 
 func TestApp_RunAsSubCommandIncorrectUsage(t *testing.T) {
+	// Go 1.17+ panics when invalid flag is given.
+	// Catch it here and consider the test passed.
+	defer func() {
+		if err := recover(); err == nil {
+			t.Fatal("expected error, got nothing")
+		}
+	}()
+
 	a := App{
 		Flags: []Flag{
 			StringFlag{Name: "--foo"},