Theming improvements

[y9san9]

Arising this question because of our call with @tkhorik in the past. Basically he told me that it was a mistake from his side since it doesn't really matter what theme you are on. Underlying content is going to be both black and white no matter what theme your operating system is.

But because of theming config looks scary and changing colors is always a routine thing.

What I suggest: let's just change color format!

# If you want to support theming
color = { light = "#FFFFFF", dark = "#000000" }
# If you don't care
color = "#FFFFFFFF"

It also should make it so much easier with colors in the code, since you don't have to write boilerplate in each use-site and define multiple config properties for color.

cc @y3owk1n

[y3owk1n]

Theming is also something in my mind recently. I am using base16 for colors throughout the whole system whenever is possible. My thought in this right now is that to expose some semantic values and use it:

Have a new theme section in config:

[theme]
light_bg = { light = "xx", dark = "xx" }
normal_bg = { light = "xx", dark = "xx" }
dark_bg = { light = "xx", dark = "xx" }
light_text = { light = "xx", dark = "xx" }
normal_text = { light = "xx", dark = "xx" }
dark_text = { light = "xx", dark = "xx" }

And then Neru can then populate these values into the whole system color without any further configuration. However, we should keep the *_dark and *_light fields in each UI for hard overrides.

For starters and the default config. We'll be able to strip out all of the color fields in respective UI section.

Not sure what do you think about this. I think even just black and white, different shades is needed so that it doesn't look dull.

[y3owk1n]

I don't fully understand it yet, can you write out an expected configuration for one section as an example? So that I can understand the expectation right.

[y9san9]

Take hotkeys as an example: they are either a string if you have one command or an array of strings if you have multiple of them.

I suggest to do the same with colors. Either a string to set one color in both themes or a dictionary with light and dark keys to set different colors in different themes.

Example with sticky modifiers:

[sticky_modifiers.ui]
background_color = "#FFFFAA22"

It will be the same as if you write:

[sticky_modifiers.ui]
background_color_light = "#FFFFAA22"
background_color_dark = "#FFFFAA22"

If you want to set 2 different colors, you will use this:

[sticky_modifiers.ui]
background_color = { light = "#FFFFAA22", dark = "#FFFFAA22" }

[y9san9]

Tl;dr:

• Ditch all _light, _dark colors
• Replace them with { light = ..., dark = ...}
• Allow to set color to a string if both colors are the same

[y3owk1n]

Oh now I get it. It make sense now.

[y3owk1n]

See #674