Skip to content

Commit 1ebda84

Browse files
authored
fix: parse default dimension from model metadata string (#307)
Parse default dimension from model metadata string instead of hardcoding 1024, preparing for models with different default dimensions.
1 parent b93905a commit 1ebda84

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

packages/core/src/embedding/voyageai-embedding.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,10 @@ export class VoyageAIEmbedding extends Embedding {
2929
const modelInfo = supportedModels[model];
3030

3131
if (modelInfo) {
32-
// If dimension is a string (indicating variable dimension), use default value 1024
3332
if (typeof modelInfo.dimension === 'string') {
34-
this.dimension = 1024; // Default dimension
33+
// Parse default dimension from string like "1024 (default), 256, 512, 2048"
34+
const match = modelInfo.dimension.match(/^(\d+)/);
35+
this.dimension = match ? parseInt(match[1], 10) : 1024;
3536
} else {
3637
this.dimension = modelInfo.dimension;
3738
}

0 commit comments

Comments
 (0)