Skip to content

Commit df317bf

Browse files
committed
fix: address review feedback for OpenRouter provider
- Remove trailing whitespace in embedding index export - Add OpenRouter and OPENROUTER_API_KEY to help message - Use Embedding base type instead of growing union in function signatures
1 parent 6cb1f2c commit df317bf

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

packages/core/src/embedding/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ export * from './openai-embedding';
66
export * from './voyageai-embedding';
77
export * from './ollama-embedding';
88
export * from './gemini-embedding';
9-
export * from './openrouter-embedding';
9+
export * from './openrouter-embedding';

packages/mcp/src/config.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ Environment Variables:
195195
MCP_SERVER_VERSION Server version
196196
197197
Embedding Provider Configuration:
198-
EMBEDDING_PROVIDER Embedding provider: OpenAI, VoyageAI, Gemini, Ollama (default: OpenAI)
198+
EMBEDDING_PROVIDER Embedding provider: OpenAI, VoyageAI, Gemini, Ollama, OpenRouter (default: OpenAI)
199199
EMBEDDING_MODEL Embedding model name (works for all providers)
200200
201201
Provider-specific API Keys:
@@ -204,7 +204,8 @@ Environment Variables:
204204
VOYAGEAI_API_KEY VoyageAI API key (required for VoyageAI provider)
205205
GEMINI_API_KEY Google AI API key (required for Gemini provider)
206206
GEMINI_BASE_URL Gemini API base URL (optional, for custom endpoints)
207-
207+
OPENROUTER_API_KEY OpenRouter API key (required for OpenRouter provider)
208+
208209
Ollama Configuration:
209210
OLLAMA_HOST Ollama server host (default: http://127.0.0.1:11434)
210211
OLLAMA_MODEL Ollama model name (alternative to EMBEDDING_MODEL for Ollama)

packages/mcp/src/embedding.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { OpenAIEmbedding, VoyageAIEmbedding, GeminiEmbedding, OllamaEmbedding, OpenRouterEmbedding } from "@zilliz/claude-context-core";
1+
import { Embedding, OpenAIEmbedding, VoyageAIEmbedding, GeminiEmbedding, OllamaEmbedding, OpenRouterEmbedding } from "@zilliz/claude-context-core";
22
import { ContextMcpConfig } from "./config.js";
33

44
// Helper function to create embedding instance based on provider
5-
export function createEmbeddingInstance(config: ContextMcpConfig): OpenAIEmbedding | VoyageAIEmbedding | GeminiEmbedding | OllamaEmbedding | OpenRouterEmbedding {
5+
export function createEmbeddingInstance(config: ContextMcpConfig): Embedding {
66
console.log(`[EMBEDDING] Creating ${config.embeddingProvider} embedding instance...`);
77

88
switch (config.embeddingProvider) {
@@ -76,7 +76,7 @@ export function createEmbeddingInstance(config: ContextMcpConfig): OpenAIEmbeddi
7676
}
7777
}
7878

79-
export function logEmbeddingProviderInfo(config: ContextMcpConfig, embedding: OpenAIEmbedding | VoyageAIEmbedding | GeminiEmbedding | OllamaEmbedding | OpenRouterEmbedding): void {
79+
export function logEmbeddingProviderInfo(config: ContextMcpConfig, embedding: Embedding): void {
8080
console.log(`[EMBEDDING] ✅ Successfully initialized ${config.embeddingProvider} embedding provider`);
8181
console.log(`[EMBEDDING] Provider details - Model: ${config.embeddingModel}, Dimension: ${embedding.getDimension()}`);
8282

0 commit comments

Comments
 (0)