Draft
Conversation
yaozhihang
reviewed
Dec 12, 2025
| public BooleanExpression crosses(ScalarExpression leftOperand, ScalarExpression rightOperand) { | ||
| // Oracle Database does not have a direct equivalent to PostgreSQL's st_crosses function. | ||
| // You may need to create a custom function or use a different approach. | ||
| throw new UnsupportedOperationException("crosses is not supported in Oracle Database."); |
Member
There was a problem hiding this comment.
Could we use MDSYS.sdo_relate combined with the 'mask=OVERLAPBDYINTERSECT'?
yaozhihang
reviewed
Dec 12, 2025
| protected Column getGeometryType(Table geometryData) { | ||
| // Oracle Database does not have a direct equivalent to PostgreSQL's geometry_properties column. | ||
| // You may need to create a custom function or use a different approach. | ||
| throw new UnsupportedOperationException("getGeometryType is not supported in Oracle Database."); |
Member
There was a problem hiding this comment.
The equivalent expression in Oracle looks like JSON_VALUE(geometry_properties, '$.type') ) . This is a Function expression rather than Column. We may need to change the API here.
Member
|
I think it would be helpful for testing to add the CLI parameter databaseType in this PR. |
Member
|
CityGML import/export work fine, but the import performance could be better. In my tests, importing untextured LOD2 buildings takes approx. 20s per 1000 buildings (with indexes disabled). The PostgreSQL version only needs 2 seconds. |
yaozhihang
reviewed
Dec 18, 2025
|
|
||
| @Override | ||
| public Function extent(ScalarExpression operand) { | ||
| return Function.of("sdo_mbr", operand); |
Member
There was a problem hiding this comment.
We need to use sdo_aggr_mbr here, because the extent is calculated over a column (envelpe).
# Conflicts: # citydb-operation/src/main/java/org/citydb/operation/deleter/feature/FeatureDeleter.java # citydb-operation/src/main/java/org/citydb/operation/importer/address/AddressImporter.java # citydb-operation/src/main/java/org/citydb/operation/importer/appearance/GeoreferencedTextureImporter.java # citydb-operation/src/main/java/org/citydb/operation/importer/appearance/SurfaceDataMappingImporter.java # citydb-operation/src/main/java/org/citydb/operation/importer/geometry/GeometryImporter.java # citydb-operation/src/main/java/org/citydb/operation/importer/geometry/ImplicitGeometryImporter.java # citydb-operation/src/main/java/org/citydb/operation/importer/property/AttributeImporter.java # citydb-operation/src/main/java/org/citydb/operation/importer/property/ImplicitGeometryPropertyImporter.java
BWibo
added
the
priority: critical
BWibo
added
type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Oracle adapters.