Fix DNS/DoH beacon reliability: prevent task loss and improve data exchange#321
Open
shashinma wants to merge 4 commits intoAdaptix-Framework:dev-v1.3from
Open
Fix DNS/DoH beacon reliability: prevent task loss and improve data exchange#321shashinma wants to merge 4 commits intoAdaptix-Framework:dev-v1.3from
shashinma wants to merge 4 commits intoAdaptix-Framework:dev-v1.3from
Conversation
Append DNS-specific params to existing common params instead of creating a new slice, preventing loss of sleep/jitter/killdate fields.
- Use A query type for PUT to fix TXT ACK parsing failures - Include downAckOffset in IsBusy() to stay in burst mode until ACK delivered - Remove premature hasPendingTasks resets on transient failures - Reset downAckOffset/downTaskNonce on "no data" GET response - Increase kMaxSafeFrame to 110, use lightweight inter-fragment pacing
… retry - Clear upDoneCache on new upload (offset==0) to prevent false dedup - Accept ackTaskNonce==0 for backward-compatible ACK delivery - Clean up localInflights on completed GET downloads - Transfer expired downFrags to localInflights for retry instead of dropping - Reset inflight attempts on timeout instead of deleting (indefinite retry) - Stricter encrypt_key validation (exactly 32 hex chars) - Increase dnsSafeChunkSize to 480, reduce cleanup/inflight intervals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upDoneCache(upload deduplication cache) falsely marked new task results as already processed when their size matched a previous upload — now cleared on every new upload (offset == 0)IsBusy(), remove prematurehasPendingTasksresets on transient network failureslocalInflightsfor redelivery instead of being dropped; inflights reset on timeout (infinite retry) instead of being deleted after N attemptsChanges
Dockerfile,pre_install_linux_all.shbeacon_agent/pl_main.go,pl_utils.goparamsintobuildDNSProfileParamsinstead of creating a new slicebeacon_agent/.../ConnectorDNS.cppdownAckOffset, removed falsehasPendingTasksresetsbeacon_agent/.../ConnectorDNS.hkMaxSafeFrame60 -> 110beacon_listener_dns/pl_transport.goupDoneCachededup, accept ACK withnonce==0, inflight infinite retry, stricterencrypt_keyvalidation,dnsSafeChunkSize280 -> 480