[RFC]Refactor: remove some action that passing this ptr as callback param in constructor#5004
Open
Mrpaoo wants to merge 1 commit into
Open
[RFC]Refactor: remove some action that passing this ptr as callback param in constructor#5004Mrpaoo wants to merge 1 commit into
this ptr as callback param in constructor#5004Mrpaoo wants to merge 1 commit into
Conversation
this ptr as callback param in constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #4995 , It's been danger to pass
thisas a callback ptr or do something that may throw error in constructor. its recommend to callinit()after construct. so i declare two func inClass AModulevoid init()to register callback passthisto framework,virtual void do_init()derived class can implement it and put error-throw action here rather than in constructor.Andinit()would be call afterfactory.MakeModule(), insideinit()then it calldo_init()It is noticed that i only modify the
hyprland/workspacesandAModuleconsider that overhaul every module is danger and i wasnt pretty sure if the community appreciate this refactor. So i need some advice about it. If it work, i can refactor the rest of themAnd i have no idea if it need some test code, and idk how to test the situation like this, so yes, please let me know if u have better idea!