Remove -Wno-digraphs from clang#32869
Open
peterbarker wants to merge 8 commits intoArduPilot:masterfrom
Open
Conversation
Member
|
Thanks Peter, this fix my mac build, but seems like it break the CI |
Contributor
Author
Yeah - I've pushed up another pair of patches for that. I wouldn't be surprised if Plane breaks next on QURT - people were not particularly thorough and fixed only the Copter build for spewing out the warnings for logical-operations vs bitwise-operations... |
Contributor
Author
|
... and another pair of fixes for frame size warnings... |
makes this the same as Copter and the base AP_Arming library
makes this the same as Copter and the base AP_Arming library
Contributor
Author
|
... and some more fixes for stack sizes and now one for -Wformat-truncation |
2f37886 to
374b669
Compare
tridge
requested changes
Apr 22, 2026
| #if defined(__clang_major__) | ||
| // clang doesn't understand -Wformat-truncation | ||
| #pragma GCC diagnostic push | ||
| #endof |
Contributor
There was a problem hiding this comment.
better add a link to the manual for "#endof"
| { // ensure rest of buffer survives | ||
| memset(output, 'A', 10); | ||
| //Main loop where the action takes place | ||
| #if defined(__clang_major__) |
Contributor
Author
|
Can be merged once claude says it is good .... and no compiler output (should add clang to size_compare_branches.py somehow?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes this compiler option as clang doesn't know about it. Also make unknown compiler options fatal as they may actually be important...
Classification & Testing (check all that apply and add your own)
... no vast amounts of warnings now for clang
Description
This warning was coming out a lot on clang. Compiles but warns.
Make the warning non-clang only and make future "don't know about this warning" fatal on clang.