Write: Track last editor used and fire publish event by kbrown9 · Pull Request #48382 · Automattic/jetpack

kbrown9 · 2026-04-29T15:41:41Z

Fixes RSM-773

Proposed changes

Set _last_editor_used_jetpack to write-editor for posts created or edited in the Write editor, so the wpcom_post_publish Tracks event includes correct last_editor attribution
For existing posts: set meta on page load in wpcom_write_render_admin_page(), matching the pattern used by the block and classic editors
For new posts: register the meta with show_in_rest via register_post_meta and include meta: { _last_editor_used_jetpack: 'write-editor' } in the JS save request, following the same pattern used by other Jetpack meta keys (e.g. _jetpack_newsletter_access)
Fire a wpcom_write_editor_post_published client-side Tracks event on publish as a reliable baseline independent of the server-side meta

Known limitation

If a new post is published directly without a prior draft save, the server-side wpcom_post_publish event does not fire at all (it hooks draft_to_publish and auto-draft_to_publish, not new_to_publish). In this case, only the client-side wpcom_write_editor_post_published event records the publish. In practice this is rare — the Write editor's autosave creates a draft within 30 seconds, so the post will typically have a draft status before publish. If the gap between client-side and server-side event counts indicates this is happening often, we'll add an immediate save on first content change to ensure a draft exists before publish.

Does this pull request change what data or activity we track or use?

Yes:

Sets _last_editor_used_jetpack post meta to write-editor when the Write editor is used (existing meta key, new value)
Fires a new wpcom_write_editor_post_published client-side Tracks event on publish with property: post_id

Testing instructions

New post

Go to a WordPress.com site with the Write editor enabled
Navigate to /wp-admin/admin.php?page=write&flags=a8c-analytics.on
Add a title and some content, click Save draft, then click Publish
Check the Tracks dashboard for a wpcom_write_editor_post_published event
Check the Tracks dashboard for a wpcom_post_publish event with last_editor: write-editor

Existing post

Create a post using the block editor and publish it
Open the same post in the Write editor: /wp-admin/admin.php?page=write&post=<ID>&flags=a8c-analytics.on
Make a change and click Update
Check the Tracks dashboard for a wpcom_write_editor_post_published event
Check the Tracks dashboard for a wpcom_post_edit event with last_editor: write-editor

Negative test — other editors unaffected

Create a new post in the block editor and publish it
Check that the wpcom_post_publish event has last_editor: block-editor (not write-editor)

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

🤖 Generated with Claude Code

github-actions · 2026-04-29T15:42:30Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the update/write_add_last_editor_meta branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/write_add_last_editor_meta

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-04-29T15:42:52Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2026-04-29T15:47:10Z

Code Coverage Summary

Coverage changed in 4 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-block-editor/functions.editor-type.php	19/32 (59.38%)	59.38%	-1 💚
projects/packages/jetpack-mu-wpcom/src/features/launchpad/class-launchpad-task-lists.php	184/279 (65.95%)	2.15%	-6 💚
projects/packages/jetpack-mu-wpcom/src/features/write/write.php	150/229 (65.50%)	2.78%	-6 💚
projects/packages/jetpack-mu-wpcom/src/features/launchpad/launchpad-task-definitions.php	702/1511 (46.46%)	0.60%	-9 💚

Full summary · PHP report

allilevine

I'm seeing the correct Tracks events on Simple and Atomic 🎉 Claude found a few small issues, including that we should add a sanitize callback.

Set _last_editor_used_jetpack to 'write-editor' so the wpcom_post_publish tracks event includes correct editor attribution: - Existing posts: set meta on page load in wpcom_write_render_admin_page() - New posts: set meta via rest_after_insert_post hook using Referer check - Fire wpcom_write_editor_post_published client-side tracks event on publish as a reliable baseline independent of the server-side meta Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

…r tracking The Referer-based approach didn't work on WPCOM because REST API requests go through the public-api.wordpress.com proxy, replacing the Referer header. Switch to register_post_meta with show_in_rest, matching the established pattern used by other Jetpack meta keys (e.g. _jetpack_newsletter_access). The JS now includes the meta directly in the save request body. Also drops is_new_post from the client-side tracks event. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The registration was in write.php, which is gated behind the wpcom-write-editor blog sticker. On WPCOM, the REST proxy resolves the target blog after plugins_loaded, so the sticker check fails and write.php isn't loaded for REST requests. Move to functions.editor-type.php which loads unconditionally and is already the home for _last_editor_used_jetpack logic. The meta key is universal (block and classic editors already write to it on every site), so ungated registration is the correct shape. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Test that existing posts get _last_editor_used_jetpack set on page load - Test that the meta overwrites a previous editor value - Test that the meta key is registered for REST API access Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Add sanitize_callback that allowlists known editor values - Wrap register_post_meta in add_action('init') for correct timing - Reuse EditorType\remember_editor() instead of raw update_post_meta - Use current_user_can() instead of wp_get_current_user()->has_cap() - Add test for sanitize callback rejection of invalid values Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

kbrown9 added the [Status] In Progress label Apr 29, 2026

kbrown9 self-assigned this Apr 29, 2026

kbrown9 added [Status] Needs Tracks Review Added/removed/modified a tracks event. [mu wpcom Feature] Write labels Apr 29, 2026

github-actions Bot added the [Package] Jetpack mu wpcom WordPress.com Features label Apr 29, 2026

github-actions Bot added [mu wpcom Feature] WordPress.com Block Editor [Tests] Includes Tests labels Apr 29, 2026

kbrown9 added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 29, 2026

kbrown9 requested a review from allilevine April 29, 2026 21:57

allilevine reviewed Apr 30, 2026

View reviewed changes

kbrown9 force-pushed the update/write_add_last_editor_meta branch from 5e4b58e to 8b49ae4 Compare April 30, 2026 15:22

kbrown9 and others added 5 commits April 30, 2026 14:26

kbrown9 force-pushed the update/write_add_last_editor_meta branch from 8b49ae4 to 8a554a9 Compare April 30, 2026 18:31

kbrown9 and others added 2 commits May 1, 2026 08:46

Write: Use sanitize_text_field for last editor meta

f88feb3

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Write: Replace allowlist test with sanitization integration test

ff44314

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

kbrown9 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Write: Track last editor used and fire publish event#48382

Write: Track last editor used and fire publish event#48382
kbrown9 wants to merge 7 commits intotrunkfrom
update/write_add_last_editor_meta

kbrown9 commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

jp-launch-control Bot commented Apr 29, 2026 •

edited

Loading

Uh oh!

allilevine left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

kbrown9 commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Known limitation

Does this pull request change what data or activity we track or use?

Testing instructions

New post

Existing post

Negative test — other editors unaffected

Uh oh!

github-actions Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

jp-launch-control Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

allilevine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kbrown9 commented Apr 29, 2026 •

edited

Loading

github-actions Bot commented Apr 29, 2026 •

edited

Loading

jp-launch-control Bot commented Apr 29, 2026 •

edited

Loading