Skip to content

Write: Keep selected text highlighted while the link popover is open#48383

Merged
allilevine merged 1 commit intotrunkfrom
fix/write-link-selection-highlight
Apr 30, 2026
Merged

Write: Keep selected text highlighted while the link popover is open#48383
allilevine merged 1 commit intotrunkfrom
fix/write-link-selection-highlight

Conversation

@allilevine
Copy link
Copy Markdown
Member

@allilevine allilevine commented Apr 29, 2026

Fixes RSM-1599

Proposed changes

  • Use the CSS Custom Highlight API to visually highlight selected text while the link popover is open, so users can see which text will receive the link even though focus moves to the URL input.
  • When the cursor is collapsed inside an existing link and the link popover is opened, auto-select the full link text and highlight it.
  • Clear the highlight in all close paths (Apply, Remove, Enter, Escape, outside click, toggle off).
link.highlighting.mov

Related product discussion/links

  • RSM-1599

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Go to the Write editor (/wp-admin/admin.php?page=write)
  • Type some text (e.g. "Hello world foo bar")
  • Select a portion of text (e.g. "world foo")
  • Click the Link button in the toolbar
  • Verify: the selected text stays visually highlighted with a blue background while the URL input is focused. It's intentionally slightly different from the selection background (which we can't match exactly with this api).
  • Type a URL and press Enter — verify the link is applied to the correct text
  • Click inside the linked text, then click the Link button again
  • Verify: the full link text is highlighted and the URL is pre-filled
  • Press Escape — verify the highlight is removed
  • Repeat and click outside the popover — verify the highlight is removed
  • Test with bold/italic text selections to ensure cross-boundary selections work

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

When selecting text and clicking the Link button, the selection highlight
disappeared because focus moved to the URL input. Use the CSS Custom
Highlight API to maintain a visual highlight over the selected text while
the popover is open. Also auto-selects the full link text when clicking
into an existing link and opening the popover.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@allilevine allilevine added the [Status] Needs Review This PR is ready for review. label Apr 29, 2026
@allilevine allilevine self-assigned this Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the fix/write-link-selection-highlight branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/write-link-selection-highlight

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@allilevine allilevine requested a review from kbrown9 April 29, 2026 16:17
@kbrown9
Copy link
Copy Markdown
Member

kbrown9 commented Apr 30, 2026

This tested well for me, and the code changes look good.

I did run into a pre-existing issue where closing the link popover with Escape or an outside click sets the cursor to the beginning of the content. I'll open a Linear issue for that.

@allilevine allilevine merged commit 49ea70e into trunk Apr 30, 2026
75 checks passed
@allilevine allilevine deleted the fix/write-link-selection-highlight branch April 30, 2026 13:24
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants