Write: Keep selected text highlighted while the link popover is open#48383
Write: Keep selected text highlighted while the link popover is open#48383allilevine merged 1 commit intotrunkfrom
Conversation
When selecting text and clicking the Link button, the selection highlight disappeared because focus moved to the URL input. Use the CSS Custom Highlight API to maintain a visual highlight over the selected text while the popover is open. Also auto-selects the full link text when clicking into an existing link and opening the popover. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
|
This tested well for me, and the code changes look good. I did run into a pre-existing issue where closing the link popover with Escape or an outside click sets the cursor to the beginning of the content. I'll open a Linear issue for that. |
Fixes RSM-1599
Proposed changes
link.highlighting.mov
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
/wp-admin/admin.php?page=write)Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com