Skip to content

CRM: Address listview count string replace mismatch#48396

Merged
tbradsha merged 2 commits intotrunkfrom
fix/crm/address_listview_count_replace_mismatch
Apr 30, 2026
Merged

CRM: Address listview count string replace mismatch#48396
tbradsha merged 2 commits intotrunkfrom
fix/crm/address_listview_count_replace_mismatch

Conversation

@tbradsha
Copy link
Copy Markdown
Contributor

Proposed changes

In #46809 PHPCS autofixes were applied. This changed two %s in a single string to %1$s and %2$s (which is the typical correct thing to do). However, in this case the string was passed to JS where it was replaced with literal replace( %s ) calls.

The easy fix is to update the string it's looking for, which is what this PR does. I didn't see any other instances of this problem.

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  1. Create a contact.
  2. Go to the contact listview.

In trunk, it'll look like this:
image

In this branch it'll look like this:
image

@tbradsha tbradsha requested review from a team and coder-karen April 29, 2026 21:07
@tbradsha tbradsha self-assigned this Apr 29, 2026
@tbradsha tbradsha added the [Status] Needs Review This PR is ready for review. label Apr 29, 2026
@github-actions github-actions Bot added the [Plugin] CRM Issues about the Jetpack CRM plugin label Apr 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

Copy link
Copy Markdown
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward. Haven't tested.

@tbradsha tbradsha merged commit da72ce5 into trunk Apr 30, 2026
71 checks passed
@tbradsha tbradsha deleted the fix/crm/address_listview_count_replace_mismatch branch April 30, 2026 13:48
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] CRM Issues about the Jetpack CRM plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants