Skip to content

Add ArmListBySubscriptionScope operation template for subscription-level listing#4185

Open
Copilot wants to merge 2 commits intomainfrom
copilot/fix-unexpected-path-listbysubscription
Open

Add ArmListBySubscriptionScope operation template for subscription-level listing#4185
Copilot wants to merge 2 commits intomainfrom
copilot/fix-unexpected-path-listbysubscription

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026 •
edited
Loading

  • Add ArmListBySubscriptionScope operation template in operations.tsp
  • Add test in resource-resolution.test.ts verifying resolveArmResources for child resource subscription scope
  • Add test in typespec-autorest/test/arm/resources.test.ts verifying correct OpenAPI path output
  • Update user documentation in resource-operations.md (table recommends ArmListBySubscriptionScope)
  • Rebuild reference documentation (regen-docs)
  • Apply review feedback: update JSDoc comments per suggestions
  • Apply review feedback: simplify docs table (remove separate children row)
  • Apply review feedback: change table to recommend ArmListBySubscriptionScope instead of ArmListBySubscription
  • Create changeset for the change
  • Rebased onto latest main — no merge conflicts, only PR changes in diff
  • All 52 resource-resolution tests pass, all 16 autorest ARM tests pass
  • All files correctly formatted

Copilot AI linked an issue Apr 2, 2026 that may be closed by this pull request
Unexpected path for listBySubscription #3903
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library emitter:autorest Issues for @azure-tools/typespec-autorest emitter meta:website TypeSpec.io updates labels Apr 2, 2026
Copilot AI changed the title [WIP] Fix unexpected path for listBySubscription Add ArmListBySubscriptionScope operation template for child resource subscription-level listing Apr 2, 2026
Copilot AI requested a review from markcowl April 2, 2026 21:16
markcowl
markcowl requested changes Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull the latest from main. Create a changeset for this change. Make the suggested changes.

Then verify that all tests pass, all files are correctly formatted and there are no merge issues with main

Comment thread packages/typespec-azure-resource-manager/lib/operations.tsp Outdated
Comment thread packages/typespec-azure-resource-manager/lib/operations.tsp Outdated
Comment thread packages/typespec-azure-resource-manager/lib/operations.tsp Outdated
Comment thread packages/typespec-azure-resource-manager/lib/operations.tsp Outdated
Comment thread packages/typespec-azure-resource-manager/lib/operations.tsp Outdated
Comment thread website/src/content/docs/docs/howtos/ARM/resource-operations.md Outdated
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 2, 2026

Pull the latest from main. Create a changeset for this change. Make the suggested changes.

Then verify that all tests pass, all files are correctly formatted and there are no merge issues with main

Done in 2ec3635 — merged latest from main (no conflicts), applied all suggested changes, created changeset, regenerated docs, verified formatting and all tests pass (47 resource-resolution + 16 autorest ARM tests).

Copilot AI changed the title Add ArmListBySubscriptionScope operation template for child resource subscription-level listing Add ArmListBySubscriptionScope operation template for subscription-level listing Apr 2, 2026
Copilot AI requested a review from markcowl April 2, 2026 22:19
markcowl
markcowl reviewed Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@markcowl markcowl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot make the suggested changes, ensure all tests pass and all files are correctly formatted. pull the latest from main and ensure that only your changes are in the pr

Comment thread website/src/content/docs/docs/howtos/ARM/resource-operations.md Outdated
Copilot AI requested a review from markcowl April 3, 2026 22:04
markcowl
markcowl requested changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

Please fix this issue, ensure all files are formatted correctly, pull the latest from main and ensure that only your changes are in the PR and there are no merge issues

Comment thread website/src/content/docs/docs/howtos/ARM/resource-operations.md Outdated
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 3, 2026

@copilot

Please fix this issue, ensure all files are formatted correctly, pull the latest from main and ensure that only your changes are in the PR and there are no merge issues

Fixed in 6ee7d9b — updated the table row to use ArmListBySubscriptionScope, formatted all files, confirmed no merge issues with main, and verified only PR changes are in the diff (47 resource-resolution + 16 autorest ARM tests pass).

Copilot AI requested a review from markcowl April 3, 2026 23:04
@markcowl
Copy link
Copy Markdown
Member

markcowl commented Apr 14, 2026

@copilot Pull the latest from main, fix any merge conflicts, validate that all files are correctly formatted, all tests pass, and that only your changes are in the pr

Copilot AI force-pushed the copilot/fix-unexpected-path-listbysubscription branch from 6ee7d9b to ea92e0a Compare April 14, 2026 01:57
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 14, 2026

@copilot Pull the latest from main, fix any merge conflicts, validate that all files are correctly formatted, all tests pass, and that only your changes are in the pr

Rebased onto latest main in ea92e0a — the PR now has a single clean commit on top of main with only my 7 changed files. All 52 resource-resolution tests and 16 autorest ARM tests pass, all files formatted correctly, no merge conflicts.

@markcowl markcowl marked this pull request as ready for review April 14, 2026 18:04
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Apr 14, 2026

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

Add ArmListBySubscriptionScope operation template for listing resources at the subscription scope with a flat path, useful for child resources that need a subscription-level list operation without parent path segments.

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Apr 14, 2026

You can try these changes here

🛝 Playground 🌐 Website

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 14, 2026 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-autorest@4185

npm i https://pkg.pr.new/@azure-tools/typespec-azure-resource-manager@4185

commit: e2038e9

@markcowl markcowl enabled auto-merge April 14, 2026 20:23
@markcowl markcowl added this pull request to the merge queue Apr 14, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

+1 more reviewer

@markcowl markcowl markcowl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@markcowl markcowl

Copilot code review Copilot

Labels

emitter:autorest Issues for @azure-tools/typespec-autorest emitter lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library meta:website TypeSpec.io updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected path for listBySubscription

4 participants

@markcowl @azure-sdk @timotheeguerin