Conversation
There was a problem hiding this comment.
Pull request overview
Optimizes geospatial camera panning by avoiding a full scene.pick during drag and instead computing the picking ray directly, reducing per-drag overhead in the camera movement subsystem.
Changes:
- Replace
scene.pick(...)during dragging withscene.createPickingRayToRef(...)and reuse a cachedRay. - Initialize
_tempPickingRayviaRay.Zero().
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18307/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/18307/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/18307/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
1 similar comment
|
WebGL2 visualization test reporter: |
Compute the ray directly, avoiding the more expensive scene pick.