Supports the runtime with /callee#14332
Conversation
|
DNM until this is fully clean. You may TM this for your good for now. |
|
To-do:
|
| E.desc += "\n ## Proc call chain: \n" | ||
| var/callee/callee_chain = caller | ||
| do | ||
| E.desc += "[callee_chain.src] | [callee_chain.proc]([english_list(callee_chain.args, nothing_text = "", and_text = ", ")])" |
There was a problem hiding this comment.
you are not allowed to call procs (which english_list) is in this portion of error handling code (due to problems with infinite recursion). Unless that issue has been fixed, which we have yet to establish (lummox tried? he's quite vague in the post) you need to move this below the if block that handles infinite recursion
There was a problem hiding this comment.
I am not sure what the issue is here. I haven't found any issue here locally.
There was a problem hiding this comment.
the thought is if a proc infinite recurses and gets killed by the stack depth limit, then we're like, already at the bottom of the stack when Error is called to report that. It isn't exempt from those rules.
it used to be attempting to call a proc in this situation would just kill the proc stack entirely, which is obviously bad. lumlum recently said he "fixed" this by adding an extra allotment of "space" for Error to use. this is what I'm referring to when I say we need to like, work out what that actually means.
There was a problem hiding this comment.
I suppose it seems to be okay..?
|
wait fuck this is beestation how did I end up here |
welcome to our dark and twisted server, fruitman |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |






About The Pull Request
Supports the runtime with /callee byond native type
Why It's Good For The Game
Good for debug
Testing Photographs and Procedure
Screenshots&Videos
Changelog
🆑
code: all runtime details fully describe the proc call flow
qol: Runtime window is now bigger for the readibility.
/:cl: