Conversation
|
Do we need to add the Apache LICENSE file into the wheel? I am not sure ...
to And, to avoid that the Release v7.9.3.1 files get overwritten (or the workflow errors out) when someone starts the workflow manually I woud change to in Or should I do this independent of this PR (I forgot it yesterday) |
From what I I've read, the license file is not necessary when the license is in the wheel
I would prefer that we do a test build to make sure that this fixes the license issue, but I agree that we do not want to overwrite the artifacts that were already used to create the PyPI release. I can try to do the build locally of one wheel and check that against pip-license, if needed |
Agreed I've pushed the change to set btw. the wheel delocation on Macos can take up to 20 min. Currently all artefacts are still in cache (cache expires after 7 days), so building OCCT and VTK SDKS and building OCP lib will automatically be skipped (saves hours). The wheels will always be built and the tests also run always. So you can simply start a run manually. There is no automatism for starting runs in this repo, since a run is so massive and I thought to save a few trees ... |
|
The CI run based on this branch is here. A quick check shows that the license info is in the METADATA file inside of the wheels now. I downloaded and installed a manylinux-3.13 wheel and then ran The UNKNOWN license on cadquery-ocp-proxy was because it installed the version that's available via PyPI currently, which does not have this fix. If you download any of the proxy wheels and check their METADATA file, the license is there. |
|
@bernhard-42 @jdegenstein Do you both feel comfortable with this PR being merged? |
|
+1 |
Closes #58