Review: Improve email scheduling (TAN-7439)#13632
Open
adessy wants to merge 4 commits intoTAN-7439-improve/email-schedulingfrom
Open
Review: Improve email scheduling (TAN-7439)#13632adessy wants to merge 4 commits intoTAN-7439-improve/email-schedulingfrom
adessy wants to merge 4 commits intoTAN-7439-improve/email-schedulingfrom
Conversation
adessy
changed the base branch from
master
to
TAN-7439-improve/email-scheduling
adessy
commented
Apr 14, 2026
| else | ||
| [2, -campaign.updated_at.to_i] | ||
| end | ||
| @campaigns = case parse_bool(params[:manual]) |
Contributor
Author
There was a problem hiding this comment.
Sorting campaigns at the DB level.
adessy
commented
Apr 14, 2026
adessy
commented
Apr 14, 2026
| text={<FormattedMessage {...messages.scheduled} />} | ||
| /> | ||
|
|
||
| <Text as="span" fontSize="base" m="0px" color="textSecondary"> |
Contributor
Author
There was a problem hiding this comment.
Fixes vertical alignment. I also took the liberty of swapping the label and the datetime. I think it just looks better 🙂
adessy
commented
Apr 14, 2026
| {/* eslint-disable-next-line @typescript-eslint/no-unnecessary-condition */} | ||
| {localize(project?.data.attributes.title_multiloc)} | ||
| </Text> | ||
| <> |
Contributor
Author
There was a problem hiding this comment.
This is pretty much unreachable code. I just made the minimal changes so it doesn't look too bad if we ever starts listing project campaigns here again.
Use span instead of p for inline text in campaign rows to avoid ResourceList's p { margin-bottom: 5px } override.
Standardize date font size to base in both DraftCampaignRow and SentCampaignRow.
Swap label/date order and add bullet separator for project name.
Replace Button with InputContainer + clock icon to match DateSinglePicker's styling pattern. This fixes the height inconsistency between date and time inputs without hardcoding.
adessy
force-pushed
the
TAN-7439-improve/email-scheduling-review
branch
from
b648a75 to
38a2b34
Compare
Collaborator
|
IvaKop
approved these changes
Apr 15, 2026
Contributor
IvaKop
left a comment
IvaKop
left a comment
There was a problem hiding this comment.
Suggestions look good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review comments / suggestions for https://github.com/CitizenLabDotCo/citizenlab/pull/13612/changes#r3078243409. Take what makes sense, skip what doesn't.