Draft
Conversation
Collaborator
|
…le check if attribute changed in policy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
folder_idto projectshared_permitted_attributesconditionally in project policy, not controller action.can_moderate_folder?in policy.ProjectPolicy#update?: folder/space moderators (evaluated against the persisted pre-change project) can only move a project into a folder they moderate; removing the folder requires the project to have never been published.authorize @projectcall after assign_attributes inProjectsController#updateso the policy can inspect pending folder/space changes via dirty tracking (folder_changed?/space_changed?).Changelog
Technical