Skip to content

TAN-7562 Project policy and roles#13657

Draft
luucvanderzee wants to merge 15 commits intomasterfrom
TAN-7562-project-policy-and-roles
Draft

TAN-7562 Project policy and roles#13657
luucvanderzee wants to merge 15 commits intomasterfrom
TAN-7562-project-policy-and-roles

Conversation

@luucvanderzee
Copy link
Copy Markdown
Contributor

@luucvanderzee luucvanderzee commented Apr 17, 2026

  • Adds folder_id to project shared_permitted_attributes conditionally in project policy, not controller action.
  • Extends project approval (publishing a 'never published' project) to space_moderator or project's space, by using can_moderate_folder? in policy.
  • Permits SM to delete 'never published' project in their space.
  • Adds folder-move rules to ProjectPolicy#update?: folder/space moderators (evaluated against the persisted pre-change project) can only move a project into a folder they moderate; removing the folder requires the project to have never been published.
  • Adds matching space-move rules: folder/space moderators (evaluated against the persisted pre-change project) can only assign a space they moderate, unless the space change is a side-effect of an allowed folder move; removing the space requires the project to have never been published.
  • Adds a second authorize @project call after assign_attributes in ProjectsController#update so the policy can inspect pending folder/space changes via dirty tracking (folder_changed? / space_changed?).

Changelog

Technical

  • [TAN-7562] Space Manager can now approve or delete a 'never published' project in their space + special-case policy rules when updating project's folder or space (feature in development & behind FF)

@notion-workspace
Copy link
Copy Markdown

@luucvanderzee luucvanderzee changed the base branch from master to TAN-7550-improve-project-create-form April 17, 2026 16:41
@cl-dev-bot
Copy link
Copy Markdown
Collaborator

cl-dev-bot commented Apr 17, 2026

Messages
📖 Changelog provided 🎉
📖 Notion issue: TAN-7562
📖

Run the e2e tests

📖 Check translation progress

Generated by 🚫 dangerJS against 9738db4

Base automatically changed from TAN-7550-improve-project-create-form to master April 20, 2026 13:52
@jinjagit jinjagit added this to the Department workspaces milestone Apr 22, 2026
@jinjagit jinjagit self-assigned this Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants