Skip to content

Replace fork and clone diagram with accessible Mermaid diagram#1443

Closed
ShrutiShahi18 wants to merge 1 commit into
CodeYourFuture:mainfrom
ShrutiShahi18:main
Closed

Replace fork and clone diagram with accessible Mermaid diagram#1443
ShrutiShahi18 wants to merge 1 commit into
CodeYourFuture:mainfrom
ShrutiShahi18:main

Conversation

@ShrutiShahi18
Copy link
Copy Markdown

@ShrutiShahi18 ShrutiShahi18 commented May 10, 2025

What does this change?

Common Content?

  • Block/s

Common Theme?

  • Yes

Issue number: #issue-number

Org Content?

Module | Sprint | Page Type | Block Type

Checklist

Who needs to know about this?

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2025

👷 Deploy request for cyf-curriculum pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 302376c

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2025

👷 Deploy request for cyf-piscine pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 302376c

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2025

👷 Deploy request for cyf-launch pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 302376c

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2025

👷 Deploy request for cyf-common pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 302376c

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2025

👷 Deploy request for cyf-itd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 302376c

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2025

👷 Deploy request for cyf-sdc pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 302376c

@netlify
Copy link
Copy Markdown

netlify Bot commented May 10, 2025

👷 Deploy request for cyf-tracks pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 302376c

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2025

Deploy Preview for cyf-programming ready!

Name Link
🔨 Latest commit 302376c
🔍 Latest deploy log https://app.netlify.com/sites/cyf-programming/deploys/681f404eabc5e400089a601b
😎 Deploy Preview https://deploy-preview-1443--cyf-programming.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

I approved your deploy preview, and it looks like this is currently broken: https://deploy-preview-1443--cyf-programming.netlify.app/onboarding/sprints/1/prep/#working-locally

Please can you fix up the syntax errors so that it renders?

Also, it'd be great to make the mermaid diagram look more like the image - so having the remove vs local boxes around the nodes, and the fork/clone labels on the edges between them.

You can preview this locally for debugging by:

  1. In a .env file in the repo root, setting HUGO_CURRICULUM_GITHUB_BEARER_TOKEN to point at a GitHub token of yours
  2. in the org-cyf-itp directory running npm i && npm run start:dev

@github-project-automation github-project-automation Bot moved this from 📋 Backlog to 🔖 Ready in Curriculum Planning May 12, 2025
@illicitonion
Copy link
Copy Markdown
Member

Actually, it looks like someone else filed #1444 which already meets those criteria, so we can merge that, but thank so much for taking the time to work on this!

@github-project-automation github-project-automation Bot moved this from 🔖 Ready to ✅ Done in Curriculum Planning May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants