N°8890 - Add detection of iTop API versions 1.3 and 1.4.

[jbostoen]

Base information

Question	Answer
Related to a SourceForge thread / Another PR / Combodo ticket?	No
Type of change?	Enhancement

Symptom (bug) / Objective (enhancement)

Enhancement: Ability to detect iTop API versions 1.3 and 1.4 ( https://www.itophub.io/wiki/page?id=latest:advancedtopics:rest_json#changes_history )

It also changes the logic to try most recent versions of the API first.

Proposed solution (bug and enhancement)

Just add the missing values.

Checklist before requesting a review

• I have performed a self-review of my code, and that it's compliant with Combodo's guidelines
• I have tested all changes I made on an iTop instance
• I have added a unit test, otherwise I have explained why I couldn't
• I have made sure the PR is clear and detailled enough so anyone can understand the real purpose without digging in the code

Checklist of things to do before PR is ready to merge

[jbostoen]

The exception now also contains hints on what can go wrong (invalid URL, invalid credentials, missing profile, ... ).

Before the patch; it would just try all versions; then assume iTop API version 1.0 and fail later on.

[jf-cbd]

Thanks for your PR, it got functionally accepted. We'll perform technical review in the upcoming days/weeks.

[Hipska]

Approved.

The weirdest part is that this method is only used purely for log message, so actually it doesn't add much value.

[Hipska]

@accognet Why are 1.3 and 1.4 removed and replaced by 2.0 (which doesn't exist?)

[accognet]

@accognet Why are 1.3 and 1.4 removed and replaced by 2.0 (which doesn't exist?)

That's a mistake. I started a review to correct it, but you're faster than me.