test: extract asset api browser fixture#11279
Merged
benceruleanlu merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎨 Storybook: ✅ Built — View Storybook |
Contributor
📝 WalkthroughWalkthroughThe changes refactor the test fixture structure by extracting the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1135 passed, 0 failed · 2 flaky📊 Browser Reports
|
📦 Bundle: 5.16 MB gzip 🟢 -56 BDetailsSummary
Category Glance App Entry Points — 22.3 kB (baseline 22.3 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.22 MB (baseline 1.22 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 76.6 kB (baseline 76.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 482 kB (baseline 482 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.1 kB (baseline 17.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 109 kB (baseline 109 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 2 added / 2 removed UI Components — 60.3 kB (baseline 60.3 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3 MB (baseline 3 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 344 kB (baseline 344 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 14 unchanged Vendor & Third-Party — 9.86 MB (baseline 9.86 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.57 MB (baseline 8.57 MB) • ⚪ 0 BBundles that do not match a named category
Status: 56 added / 56 removed / 79 unchanged ⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-04-15T22:23:49.440Z",
"gitSha": "b26a67ead0344c407f496d0ca178cdb83ed5f484",
"branch": "bl/extract-asset-api-fixture",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2057.705999999996,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.289999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.574,
"heapDeltaBytes": 20683880,
"heapUsedBytes": 64454640,
"domNodes": 12,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 17.138,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1990.791999999999,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.11100000000005,
"heapDeltaBytes": 19935840,
"heapUsedBytes": 63808944,
"domNodes": 15,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 14.213000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2013.5259999999562,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.2149999999999,
"heapDeltaBytes": 19978028,
"heapUsedBytes": 63978768,
"domNodes": 16,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 15.058999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1732.0990000000052,
"styleRecalcs": 71,
"styleRecalcDurationMs": 30.998000000000005,
"layouts": 12,
"layoutDurationMs": 3.3109999999999995,
"taskDurationMs": 674.242,
"heapDeltaBytes": 15604136,
"heapUsedBytes": 60619960,
"domNodes": 54,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 115.29400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1988.7130000000184,
"styleRecalcs": 82,
"styleRecalcDurationMs": 38.381,
"layouts": 12,
"layoutDurationMs": 3.2560000000000002,
"taskDurationMs": 907.3000000000001,
"heapDeltaBytes": 15991424,
"heapUsedBytes": 59644900,
"domNodes": 67,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 123.781,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2037.9970000000185,
"styleRecalcs": 81,
"styleRecalcDurationMs": 39.19,
"layouts": 12,
"layoutDurationMs": 3.1860000000000004,
"taskDurationMs": 923.4539999999998,
"heapDeltaBytes": 16000748,
"heapUsedBytes": 59517840,
"domNodes": 67,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 128.79600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.1149999999502,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.204,
"layouts": 6,
"layoutDurationMs": 0.6359999999999999,
"taskDurationMs": 277.243,
"heapDeltaBytes": 24594012,
"heapUsedBytes": 68101400,
"domNodes": 77,
"jsHeapTotalBytes": 21757952,
"scriptDurationMs": 23.94,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.3499999999676,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.552,
"layouts": 6,
"layoutDurationMs": 0.6970000000000002,
"taskDurationMs": 273.01399999999995,
"heapDeltaBytes": 24620540,
"heapUsedBytes": 68466508,
"domNodes": 77,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 16.698999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.198999999956,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.432,
"layouts": 6,
"layoutDurationMs": 0.591,
"taskDurationMs": 276.894,
"heapDeltaBytes": 24942528,
"heapUsedBytes": 68508348,
"domNodes": 78,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 22.629000000000005,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 575.8950000000027,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.415000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.66200000000003,
"heapDeltaBytes": 7094788,
"heapUsedBytes": 50694788,
"domNodes": 22,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 65.948,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 549.1469999999481,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.92800000000005,
"heapDeltaBytes": 6728672,
"heapUsedBytes": 50642792,
"domNodes": 18,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 59.179,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 568.6780000000908,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.062999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.94599999999997,
"heapDeltaBytes": 6769596,
"heapUsedBytes": 50685484,
"domNodes": 18,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 57.89999999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2029.2079999999828,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.115,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.711,
"heapDeltaBytes": 5084232,
"heapUsedBytes": 57319844,
"domNodes": -261,
"jsHeapTotalBytes": 16965632,
"scriptDurationMs": 92.923,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2045.7839999999692,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.403000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.7219999999999,
"heapDeltaBytes": 4362700,
"heapUsedBytes": 56546176,
"domNodes": -260,
"jsHeapTotalBytes": 15917056,
"scriptDurationMs": 93.286,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2054.8840000000155,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.438,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.978,
"heapDeltaBytes": 3631308,
"heapUsedBytes": 57846600,
"domNodes": -260,
"jsHeapTotalBytes": 14663680,
"scriptDurationMs": 96.91900000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2115.6610000000173,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.341,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1070.1239999999998,
"heapDeltaBytes": 21050404,
"heapUsedBytes": 74768048,
"domNodes": -260,
"jsHeapTotalBytes": 18481152,
"scriptDurationMs": 427.64799999999997,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2117.808000000025,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.903,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 984.642,
"heapDeltaBytes": 16313264,
"heapUsedBytes": 70917212,
"domNodes": -259,
"jsHeapTotalBytes": 17956864,
"scriptDurationMs": 368.464,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2104.4279999999844,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1045.9420000000002,
"heapDeltaBytes": 12290472,
"heapUsedBytes": 76446068,
"domNodes": -263,
"jsHeapTotalBytes": 16760832,
"scriptDurationMs": 396.406,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3132.1670000000095,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.898000000000001,
"layouts": 60,
"layoutDurationMs": 6.659999999999999,
"taskDurationMs": 1253.9440000000002,
"heapDeltaBytes": 9537772,
"heapUsedBytes": 66754816,
"domNodes": -263,
"jsHeapTotalBytes": 16236544,
"scriptDurationMs": 478.69599999999997,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3083.7379999999825,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.147,
"layouts": 60,
"layoutDurationMs": 6.648999999999999,
"taskDurationMs": 1263.929,
"heapDeltaBytes": 8379800,
"heapUsedBytes": 64625128,
"domNodes": -261,
"jsHeapTotalBytes": 15917056,
"scriptDurationMs": 477.94800000000004,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3152.696999999989,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.546999999999999,
"layouts": 60,
"layoutDurationMs": 6.559,
"taskDurationMs": 1238.502,
"heapDeltaBytes": -32720,
"heapUsedBytes": 56007048,
"domNodes": -264,
"jsHeapTotalBytes": 18014208,
"scriptDurationMs": 467.497,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.7090000000107,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.722,
"heapDeltaBytes": 2614380,
"heapUsedBytes": 58436900,
"domNodes": -262,
"jsHeapTotalBytes": 16441344,
"scriptDurationMs": 86.55699999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.3650000000407,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.413000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.76200000000006,
"heapDeltaBytes": 864376,
"heapUsedBytes": 56972736,
"domNodes": -266,
"jsHeapTotalBytes": 15917056,
"scriptDurationMs": 87.65800000000002,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.9750000000258,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.651000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.15100000000007,
"heapDeltaBytes": 3197344,
"heapUsedBytes": 58785576,
"domNodes": -263,
"jsHeapTotalBytes": 15917056,
"scriptDurationMs": 84.78500000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 562.8439999999841,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.444000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.985,
"heapDeltaBytes": 6802336,
"heapUsedBytes": 50582980,
"domNodes": 19,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 127.54000000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.7190000000187,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.096999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.226,
"heapDeltaBytes": 6171608,
"heapUsedBytes": 49490524,
"domNodes": 13,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 113.036,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 570.1299999999492,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.414,
"heapDeltaBytes": 8280916,
"heapUsedBytes": 60159652,
"domNodes": 16,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 125.058,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1989.2859999999928,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.323,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.92199999999997,
"heapDeltaBytes": 19912484,
"heapUsedBytes": 63635788,
"domNodes": 20,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 16.036,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.642000000009,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.719,
"heapDeltaBytes": -4292468,
"heapUsedBytes": 45533996,
"domNodes": 22,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 18.258999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.775000000076,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.466000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.66499999999996,
"heapDeltaBytes": 20114236,
"heapUsedBytes": 63962660,
"domNodes": 21,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 17.807000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2005.9210000000007,
"styleRecalcs": 84,
"styleRecalcDurationMs": 41.738,
"layouts": 16,
"layoutDurationMs": 4.589,
"taskDurationMs": 877.075,
"heapDeltaBytes": 11874480,
"heapUsedBytes": 55652336,
"domNodes": 73,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 95.826,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.8300000000113,
"styleRecalcs": 84,
"styleRecalcDurationMs": 40.8,
"layouts": 16,
"layoutDurationMs": 3.8659999999999997,
"taskDurationMs": 854.5970000000001,
"heapDeltaBytes": 11924124,
"heapUsedBytes": 55686396,
"domNodes": 72,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 101.80499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1982.5060000000576,
"styleRecalcs": 84,
"styleRecalcDurationMs": 44.37500000000001,
"layouts": 16,
"layoutDurationMs": 3.9560000000000004,
"taskDurationMs": 872.259,
"heapDeltaBytes": 12099588,
"heapUsedBytes": 57131644,
"domNodes": 72,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 94.30300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8175.357999999988,
"styleRecalcs": 251,
"styleRecalcDurationMs": 40.194,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3435.8269999999998,
"heapDeltaBytes": 24022264,
"heapUsedBytes": 76071312,
"domNodes": -258,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 1199.429,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8149.37500000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.68099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3390.796,
"heapDeltaBytes": 23058188,
"heapUsedBytes": 77033892,
"domNodes": -261,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 1170.6760000000002,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8158.365000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3637.162,
"heapDeltaBytes": 8323900,
"heapUsedBytes": 61640732,
"domNodes": -245,
"jsHeapTotalBytes": 24276992,
"scriptDurationMs": 1338.34,
"eventListeners": -108,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10672.101999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10659.451999999997,
"heapDeltaBytes": -55333892,
"heapUsedBytes": 160296672,
"domNodes": -9850,
"jsHeapTotalBytes": 13459456,
"scriptDurationMs": 527.123,
"eventListeners": -23961,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10915.744000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10901.816,
"heapDeltaBytes": -61264100,
"heapUsedBytes": 160686132,
"domNodes": -9852,
"jsHeapTotalBytes": 17518592,
"scriptDurationMs": 549.934,
"eventListeners": -23961,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11778.949000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11765.819000000001,
"heapDeltaBytes": -44198520,
"heapUsedBytes": 169215240,
"domNodes": -9850,
"jsHeapTotalBytes": 26566656,
"scriptDurationMs": 588.564,
"eventListeners": -23959,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14021.636,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14001.254,
"heapDeltaBytes": -62905752,
"heapUsedBytes": 161853376,
"domNodes": -9850,
"jsHeapTotalBytes": -13541376,
"scriptDurationMs": 820.2669999999999,
"eventListeners": -23955,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13616.26599999994,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.817000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13595.011999999999,
"heapDeltaBytes": -43795928,
"heapUsedBytes": 167687224,
"domNodes": -9849,
"jsHeapTotalBytes": 26566656,
"scriptDurationMs": 807.3399999999999,
"eventListeners": -23957,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14494.027000000075,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.145999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14466.988999999998,
"heapDeltaBytes": -71795668,
"heapUsedBytes": 150247384,
"domNodes": -9850,
"jsHeapTotalBytes": -12492800,
"scriptDurationMs": 881.697,
"eventListeners": -23983,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 463.6249999999791,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.101999999999997,
"layouts": 5,
"layoutDurationMs": 1.4069999999999998,
"taskDurationMs": 125.34400000000001,
"heapDeltaBytes": 5358232,
"heapUsedBytes": 52070520,
"domNodes": 168,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.835,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 461.2650000000258,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.914999999999996,
"layouts": 5,
"layoutDurationMs": 1.335,
"taskDurationMs": 117.90100000000001,
"heapDeltaBytes": 5122916,
"heapUsedBytes": 50138960,
"domNodes": 156,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 28.595000000000002,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 449.22299999996085,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.044999999999998,
"layouts": 4,
"layoutDurationMs": 1.079,
"taskDurationMs": 103.97799999999998,
"heapDeltaBytes": 4974640,
"heapUsedBytes": 50456496,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 22.714,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11279 +/- ##
===========================================
- Coverage 64.29% 44.18% -20.12%
===========================================
Files 1459 1350 -109
Lines 83830 69273 -14557
Branches 23150 19218 -3932
===========================================
- Hits 53900 30609 -23291
- Misses 28970 38064 +9094
+ Partials 960 600 -360
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dosubot
Bot
added
the
size:S
DrJKL
approved these changes
Apr 19, 2026
DrJKL
reviewed
Apr 19, 2026
Contributor
DrJKL
left a comment
DrJKL
left a comment
There was a problem hiding this comment.
So the only thing using the assetApi helper was the test of the helper itself?
Member
Author
I believe so, it was added in a test/fixtures only PR from Christian |
DrJKL
pushed a commit
that referenced
this pull request
Apr 20, 2026
## Summary Move asset API mocking off `ComfyPage` and into a standalone Playwright fixture. ## Changes - add `assetApiFixture` for browser tests that need asset API mocking - remove `assetApi` from `ComfyPage` - migrate `browser_tests/tests/assetHelper.spec.ts` to use the standalone fixture ## Why This is the first slice of the browser-fixture split. It reduces global fixture surface area without changing test behavior. ## Validation - `pnpm typecheck:browser` - `pnpm exec oxlint browser_tests/fixtures/ComfyPage.ts browser_tests/fixtures/assetApiFixture.ts browser_tests/tests/assetHelper.spec.ts --type-aware` - repo hooks during commit/push: `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm knip` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11279-test-extract-asset-api-browser-fixture-3436d73d3650818393bcd43dc909c8a2) by [Unito](https://www.unito.io)
snomiao
pushed a commit
that referenced
this pull request
Apr 22, 2026
## Summary Move asset API mocking off `ComfyPage` and into a standalone Playwright fixture. ## Changes - add `assetApiFixture` for browser tests that need asset API mocking - remove `assetApi` from `ComfyPage` - migrate `browser_tests/tests/assetHelper.spec.ts` to use the standalone fixture ## Why This is the first slice of the browser-fixture split. It reduces global fixture surface area without changing test behavior. ## Validation - `pnpm typecheck:browser` - `pnpm exec oxlint browser_tests/fixtures/ComfyPage.ts browser_tests/fixtures/assetApiFixture.ts browser_tests/tests/assetHelper.spec.ts --type-aware` - repo hooks during commit/push: `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm knip` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11279-test-extract-asset-api-browser-fixture-3436d73d3650818393bcd43dc909c8a2) by [Unito](https://www.unito.io)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move asset API mocking off
ComfyPageand into a standalone Playwright fixture.Changes
assetApiFixturefor browser tests that need asset API mockingassetApifromComfyPagebrowser_tests/tests/assetHelper.spec.tsto use the standalone fixtureWhy
This is the first slice of the browser-fixture split. It reduces global fixture surface area without changing test behavior.
Validation
pnpm typecheck:browserpnpm exec oxlint browser_tests/fixtures/ComfyPage.ts browser_tests/fixtures/assetApiFixture.ts browser_tests/tests/assetHelper.spec.ts --type-awarepnpm typecheck,pnpm typecheck:browser,pnpm knip┆Issue is synchronized with this Notion page by Unito