Add locallib JavaFX jars to compile classpath#109
Open
alexeid wants to merge 1 commit intoCompEvol:masterfrom
Open
Add locallib JavaFX jars to compile classpath#109alexeid wants to merge 1 commit intoCompEvol:masterfrom
alexeid wants to merge 1 commit intoCompEvol:masterfrom
Conversation
The locallib/ directory ships javafx.base/controls/fxml/graphics/... jars but the compile classpath only pulled in jam.jar, testfx.jar and assertj. Builds therefore failed with 'package javafx.geometry does not exist' on any JDK that does not bundle JavaFX (i.e. anything other than the Zulu FX referenced by the openjre* properties).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
locallib/ ships javafx.base.jar, javafx.controls.jar, javafx.fxml.jar, javafx.graphics.jar, javafx.media.jar, javafx.swing.jar, javafx.web.jar, and javafx-swt.jar, but the compile classpath only pulled in jam.jar, testfx.jar, and assertj-core-3.20.2.jar. Compilation therefore failed with "package javafx.geometry does not exist" (and ~2800 follow-on errors) on any JDK that does not bundle JavaFX — i.e. anything other than the Zulu-FX referenced by the openjre* properties.
This adds one line —
<fileset dir="${libFX}" includes="javafx*.jar"/>— so a plain JDK (Zulu/Temurin/Oracle, no FX) builds cleanly using the jars already in the repo.build_jar_all_BeastFXsucceeds end-to-end on Zulu 25 with this change.