Open
Conversation
DD_8W6DFU Co-authored-by: quinna-h <175135214+quinna-h@users.noreply.github.com>
Contributor
|
I can only run on private repositories. |
Codeowners resolved as |
quinna-h
changed the title
quinna-h
added
the
changelog/no-changelog
dubloom
reviewed
Apr 14, 2026
| The full URL (base + path) is captured in the span | ||
| """ | ||
| with snapshot_context(): | ||
| with snapshot_context(ignores=["meta._dd.svc_src"]): |
Contributor
There was a problem hiding this comment.
This is indeed a quick win but I don't think we should go that path.
We should probably try to understand why it appears/disappears
Collaborator
There was a problem hiding this comment.
Somewhat related is this PR that adjusts for the new _dd.svc_src tag: #17558
Collaborator
There was a problem hiding this comment.
It's also the case that this ignore is applied globally, so I would expect this change to be a no-op.
emmettbutler
requested changes
Apr 15, 2026
Collaborator
emmettbutler
left a comment
emmettbutler
left a comment
There was a problem hiding this comment.
This conflicts with the near-term goal of including svc_src in snapshot comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixing
test_base_url[py3.13]• Questions? Ask in #code-gen-flaky-testsThis change stabilizes the
test_base_url[py3.13]flaky snapshot assertion intests/contrib/aiohttp/test_aiohttp_client.py.This test has a high CI impact (2.7% flake rate). The failure was caused by nondeterministic presence of the
_dd.svc_srcspan meta tag in theaiohttp.requestsnapshot, which made snapshot comparison fail when the tag appeared.Changes
test_base_urlto callsnapshot_context(ignores=["meta._dd.svc_src"]).Testing
ruff format tests/contrib/aiohttp/test_aiohttp_client.py(no changes).ruff check --fix tests/contrib/aiohttp/test_aiohttp_client.py(passed).Risks
Low. The change is isolated to one test and only ignores a nondeterministic metadata tag that is not part of the functional behavior being validated (base URL expansion in aiohttp request spans).
Additional Notes
None.
PR by Bits - View session in Datadog
Comment @DataDog to request changes