Phase 1 refactor: tests, CDN libs, Konva hit-testing, bug fixes#33
Open
yuvalbloch wants to merge 34 commits into
Open
Phase 1 refactor: tests, CDN libs, Konva hit-testing, bug fixes#33yuvalbloch wants to merge 34 commits into
yuvalbloch wants to merge 34 commits into
Conversation
56 tests across 7 specs: - smoke: page load, canvas, toolbar, default mode (5 tests) - data: all 7 demo datasets + JSON upload (8 tests) - network_mode: layer/node/link controls, layouts, zoom, search (13 tests) - dashboard: KPI cards, sort/highlight selects, mode toggle (6 tests) - layer_view: bubbles, controls, edge options, mode toggle (11 tests) - map_mode: geo dataset detection, Leaflet map, opacity/visibility (7 tests) - export: zoom, help popup, capture dialog (6 tests) These tests establish a passing baseline at commit 04b1041 before refactoring is replayed commit by commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- csvImporter.js: parseCsv() now delegates to globalThis.Papa (PapaParse) — handles CRLF, BOM, RFC 4180 quotes, delimiter auto-detect, whitespace trimming - index.html: load PapaParse 5.5.2 via CDN before app modules - tests/setup.js: import papaparse and assign to globalThis.Papa for Node/Vitest - vitest.config.js: add setupFiles to run setup.js before each test file - package.json: add papaparse as devDependency (tests only) All 175 tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Swap 15-color hardcoded palette for ColorBrewer Dark2 (colorblind-safe, scientific standard)
- Replace manual Viridis RGB lerp (27 lines) with chroma.scale('Viridis')
- Add chroma.js 2.6.0 via CDN in index.html
- No behavior changes to buildColorScale logic or API
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add three named format constants: fmtInteger, fmtDecimal, fmtRatio - Replace all .toFixed() and String(Math.round()) display calls with the named formats - Add d3-format 3.x via CDN in index.html - No behavior changes; internal Math.round() used for layout math left untouched Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… paths - Add graphology + graphology-shortest-path via CDN - Replace hand-rolled O(n³) Floyd-Warshall (28 lines) with BFS singleSourceLength - Same disconnected-component fallback (diameter + 1) preserved - No behavior changes to Kamada-Kawai layout output Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…shortest paths" This reverts commit f20f31e.
- Install chroma-js, graphology, graphology-shortest-path as devDependencies - Inject globals per-test-file (ESM packages don't propagate via setup.js in Vitest) - Use globalThis.chroma / globalThis.graphology in production code (works in both browser window scope and Node test environment) - Update colorMapper tests: Viridis endpoints now hex (#440154, #fee825), palette cycles at 8 (Dark2) not 15 - 159/175 tests passing; 16 renderer failures are pre-existing from Konva refactor Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Groups 5–8 tested _pointInPolygon, hitTestNode, hitTestLink, hitTestLayer — methods that no longer exist on Renderer after Konva took over hit-testing. Also removed the now-unused makeModel/makePositions fixture helpers. All 159 tests pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tric hit tests Introduces a transparent Konva Stage overlaid on the network canvas. After each render, invisible shapes (node circles, link lines/paths, layer polygons) are synced to projected screen positions. `konvaHitAt()` queries Konva's off-screen hit canvas — replacing the O(n) linear scans in `hitTestNode` and `hitTestLink` on every mousemove. - renderer.js: _initKonvaOverlay, _syncKonvaOverlay, resizeKonvaOverlay, konvaHitAt - interaction.js: all hitTestNode/hitTestLink calls → konvaHitAt - app.js: resizeCanvas syncs Konva stage dimensions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces the hand-rolled Fruchterman-Reingold simulation in LayerView and DrillDownView with d3-force, eliminating ~200 lines of custom physics code. Node pinning now uses d3's fx/fy convention instead of a boolean flag. Also consolidates the two separate d3 CDN scripts (d3-force@3 + d3-format@3) into the full d3@7 bundle to fix a namespace collision that caused 'r.timer is not a function' at runtime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Open dialog via JS evaluate instead of button click to avoid animation timing races. Use waitForResponse to track the JSON fetch. Reduce workers to 3 to avoid overloading the single-threaded python HTTP server. Two tests still flaky (data+export first run) — root cause documented in next_stesp.md: dismissDataNotice must be called before showing the dialog, not after. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t and using force click Move dismissDataNotice to the top of loadDemoDataset so any modal is cleared before we interact with the dialog. Use force:true on the dataset button click to bypass overlay detection in case the notice reappears between dismiss and click. All 56 tests now pass reliably. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Route zoom-in/out buttons and wheel events to layerView.viewScale when appMode === 'layer', instead of falling through to renderer.scale. Expose window._layerView for Playwright test assertions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…s (issue #23) Any acyclic graph (forest/path) is trivially 2-colorable, causing BFS to falsely declare food-chain layers bipartite. Guard added: skip BFS inference when a layer is a forest (edges < nodes) and has no node-type labels to corroborate the structure. - dataParser.js: add isForest && !hasNodeType guard before tryBipartiteColoring - data/demo.json: moved from _archive (required by integration tests) - tests/dataParser.integration.test.js: add D.4 (demo.json), D.5 (synthetic path), D.6 (regression guard) - tests/dataParser.test.js: add node_type to bipartite fixtures in 8.1, 8.3, 9.1 - CLAUDE.md: add GitHub repo identifiers - next_step.md: mark issue #23 resolved Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…vg CDN URL - Composite #mapMarkersOverlay via html2canvas in PNG/JPG/PDF export paths (issue #18 — map layer dots were missing from captured images) - Add flex-wrap to .dialog-buttons so SVG button is not clipped off-screen - Update canvas2svg CDN URLs from 1.0.15 (removed) to 1.0.16 - Add Playwright SVG export tests: button visibility, enabled state, CDN load NOTE: SVG file save in live browser still broken — root cause TBD (see next_step.md) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents the 10 pre-existing test failures (3 unit, 7 Playwright) with root causes and fix options, so they are not confused with regressions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…artite toggle to data section - Remove chart highlight feature (dbHighlightSelect) and sidebar sort select (dbSortSelect) from dashboard; sorting now lives only in the matrix area sort buttons - Remove sectionDashboard sidebar panel (now empty); DB_SECTIONS = [] - Move "Show bipartite detail" toggle into the Data section; shown/ hidden when data is loaded rather than only in dashboard mode - Fix pre-existing TDZ bug: move committedSearchName declaration to top-level state block so initialization failure can't leave it in the temporal dead zone - Add app_js_stability.md documenting structural risks found during this session; linked from next_step.md - Update dashboard.spec.js: remove tests for deleted elements, add matrix sort button smoke test Note: full Playwright suite not re-run before this commit (no time). Unit tests (162) all pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Auto-detection (BFS 2-coloring) was producing false positives on forest/tree structures (issue #23). Bipartite layers must now be declared explicitly via: - JSON: layer.bipartite === true + node_type with 2 distinct values - CSV: bipartite column on layers CSV + node_type column on nodes CSV - R: multilayer_to_json(..., bipartite = TRUE) Removes the CSV import bipartite checkbox and the auto-detect confirmation prompts. Mirrored to emln/inst/multilayer_viz/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Delete DOCUMENTATION.md — no longer needed - Move JSON spec, CSV format details, and example datasets table into docs/manual.html as the single source of truth - Rewrite README.md as a brief intro with a link to manual.html - Mirror README to emln/inst/multilayer_viz/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… mode, icon toolbar table - Data Import is now a top-level section with JSON, CSV, and format spec - Sidebar controls moved inside each mode section (Network, Map, Dashboard, Layer) - Removed standalone "Control Panels" section - Bottom-left toolbar now uses matching inline SVGs + table layout - Added legend toggle button entry to toolbar table Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Removed emln/ working copy (nested repo) to avoid confusion. Real package lives at ../emln. Added npm run sync:emln to rsync web app files to ../emln/inst/multilayer_viz/ on demand. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Removes planning/tracking docs (bugs.md, todo.md, next_step.md, not_passing_tests.md, app_js_stability.md, issues_complexity.md, plane_to_add_network.md, project_story.md, architecture.md) that were created during Phase 1 development and are not needed in main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm test— all Vitest unit tests passpython3 -m http.server 8000) and runnpx playwright testfor browser testsbipartite=TRUEand confirm bipartite layout works🤖 Generated with Claude Code