Made ORSTools ready for qgis_process#325
Made ORSTools ready for qgis_process#325jannefleischer wants to merge 80 commits intoGIScience:mainfrom
Conversation
…s a integer parameter as string)
…se with qgis_process in an headless environment.
koebi
left a comment
There was a problem hiding this comment.
Hey,
thanks a lot for the contribution!
I had a quick look at everything but the new processing algorithm - will have to look at that one in detail :)
|
Thanks for the feedback, removed old stuff. |
…and hopefully test for 3.16 runs...).
…r/orstools-qgis-plugin into qgis_process_ready
…r/orstools-qgis-plugin into qgis_process_ready
…rnal plugins (especially headless))
Added sink commitment following qgis-pull-request #59241
Added sink commitment following qgis-pull-request #59241
This reverts commit 89ad098.
|
Hi, this would be a really cool feature to have I think. I would however be -1 on introducing three new processing algorithms for this sole reason. @koebi proposed to hide the new processing algorithms from the toolbox. Could you have a look at how that would work? Otherwise I'd also be open for a video call to discuss details if you would like. |
|
Though currently it isn't beautiful that there are (somewhat) double structures to modify config. Maybe modify gui to use the processing tool internally, too. To safe code lines. Edit: A, now I understand what you are saying. I'll check how to useHideFromToolbox-flag... |
|
So, I have hidden the algorithms now. Though should be documented somewhere that they exist? |
|
@koebi Anything to be done before merged? |
|
Hey,
Do you have any idea why the tests do not run completely? |
|
I have absolutely no clue. And if I initiate them locally I almost instantly hit my apikey-limit. So sadly I am no help here :/ . |
- Added `pre-commit` to requirements for code quality checks. - Refactored `pytest_sessionstart` in `conftest.py` to ensure API key is set correctly. - Enhanced `TestCommon` to include retry logic for OverQueryLimit in client requests. - Updated `TestGui` to improve mouse event handling and added cleanup in `tearDown`. - Implemented new tests in `TestProc` for directions layer optimization. - Refactored field creation tests in `test_wrapper.py` to use unified `create_qgs_field` function. - Fixed imports in `qgis_interface.py` to use the correct PyQt5 module from QGIS.
|
@koebi I have included changes from main into this. THough haven't tested my work at all with the new changes. Could you maybe have the test run on this? |
|
When I run the tests in my fork, everything runs fine. https://github.com/jannefleischer/orstools-qgis-plugin/actions/runs/22182555888 |
Because I need to run our plugin OS-WALK-EU (which depends on isocrone calculations from ORStools) from within a qgis_process setup headless I needed some upstream changes:
Now I can run something like this from the command line:
followed by:
Due to
None/null-Values and[]as parameters, only the json-piping is working.