Bring event host tests to WheelEvent-level coverage by Copilot · Pull Request #1118 · HtmlUnit/htmlunit

Copilot · 2026-05-12T15:48:37Z

This PR raises event host coverage in org.htmlunit.javascript.host.event to the same constructor/createEvent/in-window detail level used by WheelEventTest. It fills the missing standard test matrix across existing event tests and adds coverage for event classes that previously had no dedicated test file.

Expand existing event tests
- Added missing standard methods to the targeted existing suites, including:
  - constructor variants: no-arg, numeric, null, unknown symbol, arbitrary type
  - full init-dict and empty init-dict cases
  - document.createEvent(...)
  - 'EventName' in window
- Preserved all existing specialized tests and behavior-specific coverage.
- Updated per-browser alerts for restricted classes (Chrome/Edge-only and Firefox-only hosts).
Normalize event dumps
- Aligned dump helpers with the WheelEventTest pattern:
  - base fields: type, bubbles, cancelable, composed
  - event-specific getters where exposed by the host class
- Extended dumps for classes such as:
  - PopStateEvent → state
  - CloseEvent → code, reason, wasClean
  - HashChangeEvent → oldURL, newURL
  - PointerEvent → pointer-specific fields including persistentDeviceId
  - UIEvent → detail, view, which
Add missing test classes
- Added new test coverage for previously untested event hosts, including:
  - ClipboardEventTest
  - IDBVersionChangeEventTest
  - MIDIConnectionEventTest
  - MIDIMessageEventTest
  - MediaEncryptedEventTest
  - MediaKeyMessageEventTest
  - MediaQueryListEventTest
  - MediaStreamEventTest
  - MediaStreamTrackEventTest
  - MouseScrollEventTest
  - PromiseRejectionEventTest
  - RTCDataChannelEventTest
  - RTCPeerConnectionIceEventTest
  - SecurityPolicyViolationEventTest
  - SpeechSynthesisEventTest
Keep browser support explicit
- Encoded support boundaries directly in alerts using the existing convention:
  - unrestricted hosts → all browsers
  - @JsxClass({CHROME, EDGE}) → default ReferenceError for Firefox
  - @JsxClass({FF, FF_ESR}) → default ReferenceError for Chromium

Example of the standardized shape now used across event tests:

@Test
@Alerts({"[object PopStateEvent]", "popstate", "false", "false", "false", "null"})
public void create_ctor() throws Exception {
    final String html = DOCTYPE_HTML
        + "<html><head><script>\n"
        + LOG_TITLE_FUNCTION
        + "  function test() {\n"
        + "    try {\n"
        + "      var event = new PopStateEvent('popstate');\n"
        + "      dump(event);\n"
        + "    } catch(e) { logEx(e) }\n"
        + "  }\n"
        + DUMP_EVENT_FUNCTION
        + "</script></head><body onload='test()'>\n"
        + "</body></html>";

    loadPageVerifyTitle2(html);
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

central.sonatype.com
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/htmlunit/htmlunit org.codehaus.plexus.classworlds.launcher.Launcher -Dtest=WheelEventTest,PopStateEventTest,WebGLContextEventTest test (dns block)
- Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/htmlunit/htmlunit org.codehaus.plexus.classworlds.launcher.Launcher -Dtest=PopStateEventTest,UIEventTest,PointerEventTest,ClipboardEventTest,MouseScrollEventTest test grep crip�� g/htmlunit/javascript/host/event/UIEvent.java git /PointerEvent.java d " "$f" | sed "getopt --global java grep (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Goal

Every test class in src/test/java/org/htmlunit/javascript/host/event/ must reach the same detail level as WheelEventTest — the reference implementation.

The Standard Test Pattern

Study WheelEventTest carefully — it is the reference. Every event test class must contain (at minimum) these 10 test methods, adapted for the specific event class:

private static final String DUMP_EVENT_FUNCTION = "  function dump(event) {\n"
    + "    if (event) {\n"
    + "      log(event);\n"
    + "      log(event.type);\n"
    + "      log(event.bubbles);\n"
    + "      log(event.cancelable);\n"
    + "      log(event.composed);\n"
    // add event-class-specific properties here if any exist (like deltaX, deltaY for WheelEvent)
    + "    } else {\n"
    + "      log('no event');\n"
    + "    }\n"
    + "  }\n";

Required test methods (adapt alerts per browser support):

create_ctor — new EventName('type'), dump event
create_ctorWithoutType — new EventName() with no args → TypeError (use @HtmlUnitNYI if HtmlUnit doesn't throw)
create_ctorNumericType — new EventName(42) → works, logs 42 as type
create_ctorNullType — new EventName(null) → works, logs null as type
create_ctorUnknownType — new EventName(unknown) → ReferenceError
create_ctorArbitraryType — new EventName('HtmlUnitEvent') → works
create_ctorAllDetails — full init dict with event-specific fields (bubbles, cancelable, composed, plus any event-class fields)
create_ctorAllDetailsMissingData — empty init dict {}
create_createEvent — document.createEvent('EventName') → NotSupportedError/DOMException
inWindow — 'EventName' in window → true or false depending on browser support

Browser-restriction rules:

If @JsxClass has no browser restriction → all browsers supported → @Alerts("true") for inWindow, no per-browser @Alerts splits needed for constructors
If @JsxClass({CHROME, EDGE}) → DEFAULT = "ReferenceError" (FF/FF_ESR), specific Chrome/Edge alerts
If @JsxClass({FF, FF_ESR}) → DEFAULT = "ReferenceError" (Chrome/Edge), specific FF alerts

Work Items

A. Fix `PopStateEventTest` (existing file needs enhancement)

The existing file has create_ctor, create_ctorWithDetails, create_createEvent, setState, dispatchEvent, dispatchEventWithoutInit, initPopStateEvent. Keep all existing tests. Add the missing standard tests:

create_ctorWithoutType → TypeError (all browsers, @HtmlUnitNYI if needed)
create_ctorNumericType
create_ctorNullType
create_ctorUnknownType
create_ctorArbitraryType
create_ctorAllDetailsMissingData — new PopStateEvent('popstate', {})
inWindow → @Alerts("true")

The DUMP_EVENT_FUNCTION for PopStateEvent logs: event, event.type, event.bubbles, event.cancelable, event.composed, event.state.

B. Enhance existing test files that lack standard tests

For each file below, read the current content and the corresponding main source class, then add all missing standard test methods. Keep all existing tests. Also add/update the DUMP_EVENT_FUNCTION if it doesn't log the standard 5 base properties yet, and add event-class-specific properties to the dump if the main source exposes them via @JsxGetter.

Files to enhance (read each to see what's currently missing):

AudioProcessingEventTest — main: AudioProcessingEvent.java (check browser restrictions and any getters)
BeforeInstallPromptEventTest — main: BeforeInstallPromptEvent.java
BeforeUnloadEventTest — main: BeforeUnloadEvent.java
BlobEventTest — main: BlobEvent.java
CloseEventTest — main: CloseEvent.java (has code, reason, wasClean getters — include in dump and create_ctorAllDetails)
CompositionEventTest — main: CompositionEvent.java
CustomEventTest — main: CustomEvent.java (has detail getter)
DeviceMotionEventTest — main: DeviceMotionEvent.java
DeviceOrientationEventTest — main: DeviceOrientationEvent.java
DragEventTest — main: DragEvent.java
ErrorEventTest — main: ErrorEvent.java (has message, filename, lineno, colno, error getters)
FocusEventTest — main: FocusEvent.java
GamepadEventTest — main: GamepadEvent.java
HashChangeEventTest — main: HashChangeEvent.java (has oldURL, newURL getters)
InputEventTest — main: InputEvent.java
OfflineAudioCompletionEventTest — main: OfflineAudioCompletionEvent.java
PageTransitionEventTest — main: PageTransitionEvent.java (has persisted getter)
PointerEventTest — main: PointerEvent.java
StorageEventTest — main: StorageEvent.java
SubmitEventTest — main: SubmitEvent.java
TextEventTest — main: TextEvent.java
TimeEventTest — main: TimeEvent.java
TouchEventTest — main: TouchEvent.java
TrackEventTest — main: TrackEvent.java
TransitionEventTest — main: TransitionEvent.java
`UIEvent...

This pull request was created from Copilot chat.

Agent-Logs-Url: https://github.com/HtmlUnit/htmlunit/sessions/ce4e3b93-a5c2-46db-87b4-6f72659e8ee3 Co-authored-by: rbri <2544132+rbri@users.noreply.github.com>

sonarqubecloud · 2026-05-12T16:16:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Initial plan

f08949f

Copilot AI assigned Copilot and rbri May 12, 2026

Copilot started work on behalf of rbri May 12, 2026 15:48 View session

Copilot AI and others added 2 commits May 12, 2026 16:12

test: expand event host test coverage

615e417

Agent-Logs-Url: https://github.com/HtmlUnit/htmlunit/sessions/ce4e3b93-a5c2-46db-87b4-6f72659e8ee3 Co-authored-by: rbri <2544132+rbri@users.noreply.github.com>

test: add missing event test classes and methods

06b1deb

Agent-Logs-Url: https://github.com/HtmlUnit/htmlunit/sessions/ce4e3b93-a5c2-46db-87b4-6f72659e8ee3 Co-authored-by: rbri <2544132+rbri@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add test methods for event classes based on WheelEventTest~~ Bring event host tests to WheelEvent-level coverage May 12, 2026

Copilot AI requested a review from rbri May 12, 2026 16:16

Copilot finished work on behalf of rbri May 12, 2026 16:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bring event host tests to WheelEvent-level coverage#1118

Bring event host tests to WheelEvent-level coverage#1118
Copilot wants to merge 3 commits into
masterfrom
copilot/add-test-methods-for-event-classes

Copilot AI commented May 12, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Copilot AI commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Goal

The Standard Test Pattern

Work Items

A. Fix PopStateEventTest (existing file needs enhancement)

B. Enhance existing test files that lack standard tests

Uh oh!

sonarqubecloud Bot commented May 12, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 12, 2026 •

edited

Loading

A. Fix `PopStateEventTest` (existing file needs enhancement)