Tokens: Change background.neutral.strong in Thunderblocks#2977
Draft
beaesguerra wants to merge 2 commits intomainfrom
Draft
Tokens: Change background.neutral.strong in Thunderblocks#2977beaesguerra wants to merge 2 commits intomainfrom
background.neutral.strong in Thunderblocks#2977beaesguerra wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d5097bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: 0 B Total Size: 120 kB ℹ️ View Unchanged
|
Contributor
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (4e98f7e) and published all packages with changesets to npm. You can install the packages in ./dev/tools/deploy_wonder_blocks.js --tag="PR2977"Packages can also be installed manually by running: pnpm add @khanacademy/wonder-blocks-<package-name>@PR2977 |
Contributor
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-ogcovzmrbu.chromatic.com/ Chromatic results:
|
beaesguerra
force-pushed
the
token-migration-pt-2
branch
from
32b8003 to
8957de0
Compare
…ound.neutral.strong` from `black_100` to `gray_10`. If consumers are needing to use the `black_100` value, migrate it to `background.base.strong`
beaesguerra
force-pushed
the
token-migration-pt-2
branch
from
8957de0 to
d5097bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Now that
semanticColor.core.background.base.strongis updated to a dark color in #2970, we can updatesemanticColor.core.background.neutral.strongin thethunderblockstheme fromblack_100togray_10.Note: If current usage in projects are expecting the value to be
black_100, it should be updated to usebackground.base.stronginstead for the TB themeIssue: WB-2225
Test plan:
Confirm token change is expected and changes in Chromatic are expected