fix(config): fix "save as" and file extension filter#2719
Merged
JPSchellenberg merged 2 commits intoLumieducation:masterfrom Jan 15, 2026
Merged
fix(config): fix "save as" and file extension filter#2719JPSchellenberg merged 2 commits intoLumieducation:masterfrom
JPSchellenberg merged 2 commits intoLumieducation:masterfrom
Conversation
There's a split second after confirming save location where Electron couldn't find a focused window, this causes an Exception and the file isn't saved.
According to Electron's doc: https://www.electronjs.org/docs/latest/api/dialog "The extensions array should contain extensions without wildcards or dots"
Contributor
Author
|
Root cause:
Changes:
Related issue: link I've verified the fix - it works on both Windows and Linux. |
mindcrunch4u
changed the title
JPSchellenberg
approved these changes
Jan 15, 2026
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause:
Changes:
Verified by user @nettkursxyz in this issue.
According to contributing guidelines, the reviewer should be:
cc @JPSchellenberg