Skip to content

feat(keyring-eth-money): remove signTransaction pass-through#521

Draft
danroc wants to merge 7 commits intomainfrom
remove-signTransaction-money-keyring
Draft

feat(keyring-eth-money): remove signTransaction pass-through#521
danroc wants to merge 7 commits intomainfrom
remove-signTransaction-money-keyring

Conversation

@danroc
Copy link
Copy Markdown
Contributor

@danroc danroc commented Apr 20, 2026

Summary

  • Remove signTransaction pass-through method from MoneyKeyring
  • Unexport EvmSigner type and rename to MoneySigner; the type was incorrectly exported and no longer represents a full EVM signer
  • Remove corresponding test
  • Money accounts do not need to sign transactions

Changes

  • BREAKING: MoneyKeyring.signTransaction is no longer available
  • BREAKING: EvmSigner renamed to MoneySigner, no longer exported

Note

Medium Risk
Breaking API surface change for consumers that previously called MoneyKeyring.signTransaction. Implementation changes are small and localized, but may require downstream updates and could affect runtime if callers still expect the method to exist.

Overview
Removes MoneyKeyring.signTransaction so Money accounts no longer expose transaction signing via the wrapped HdKeyring (breaking change).

Tightens the internal signer typing by unexporting/renaming EvmSigner to the non-exported MoneySigner (and dropping the transaction-signing method from that interface), deletes the corresponding unit test, and documents the breaking change in the changelog.

Reviewed by Cursor Bugbot for commit 554d2db. Bugbot is set up for automated code reviews on this repo. Configure here.

Remove signTransaction from MoneyKeyring and EvmSigner type.
Money accounts do not need to sign transactions.
@danroc danroc requested a review from a team as a code owner April 20, 2026 12:59
@danroc danroc changed the title chore(money-keyring): remove signTransaction pass-through feat(keyring-eth-money): remove signTransaction pass-through Apr 20, 2026
@danroc danroc marked this pull request as draft April 20, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant