feat(keyring-eth-money): remove signTransaction pass-through#521
Draft
feat(keyring-eth-money): remove signTransaction pass-through#521
Conversation
Remove signTransaction from MoneyKeyring and EvmSigner type. Money accounts do not need to sign transactions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signTransactionpass-through method from MoneyKeyringEvmSignertype and rename toMoneySigner; the type was incorrectly exported and no longer represents a full EVM signerChanges
MoneyKeyring.signTransactionis no longer availableEvmSignerrenamed toMoneySigner, no longer exportedNote
Medium Risk
Breaking API surface change for consumers that previously called
MoneyKeyring.signTransaction. Implementation changes are small and localized, but may require downstream updates and could affect runtime if callers still expect the method to exist.Overview
Removes
MoneyKeyring.signTransactionso Money accounts no longer expose transaction signing via the wrappedHdKeyring(breaking change).Tightens the internal signer typing by unexporting/renaming
EvmSignerto the non-exportedMoneySigner(and dropping the transaction-signing method from that interface), deletes the corresponding unit test, and documents the breaking change in the changelog.Reviewed by Cursor Bugbot for commit 554d2db. Bugbot is set up for automated code reviews on this repo. Configure here.