fix: ensure mUSD is tracked by default cp-13.29.0#42333
Conversation
…. mUSD is tracked automatically as of @metamask/assets-controllers v105.1.0
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/earn (4 files, +0 -171)
🕵️ @MetaMask/extension-privacy-reviewers (1 files, +1 -0)
📜 @MetaMask/policy-reviewers (12 files, +812 -232)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. |
Builds ready [c4944d4]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [280331f]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [4d23a15] [reused from 280331f]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Some E2E failures are because of the new MUSD addition flow.
We are not permitted to make API calls until after unlock or onboarding.
|
Builds ready [8792d80]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c854983. Configure here.
Builds ready [c854983]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [a406f40]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [9ed4229]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [b5a0c5e]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d4b8877] [reused from b5a0c5e]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|

Description
This PR updates dependencies to ensure that mUSD is tracked by default in the wallet; removes the previous
ensureMusdTokenImportedForChainsolution; removes ability for users to hide mUSD on the asset details page.Changes:
^105.1.0ensureMusdTokenImportedForChainChangelog
CHANGELOG entry: bumped assets-controllers to ^105.1.0; removed ensureMusdTokenImportedForChain.
Related issues
Fixes:
Manual testing steps
Prerequisite: To replicate the "insufficient balance" error in the mUSD conversion flow you must have a fresh install with an SRP that doesn't hold mUSD but does hold ETH and a convertible stablecoin (e.g. USDC).
Screenshots/Recordings
Before
mm_extension_auto_import_mUSD_demo_before.mov
After
mm_extension_auto_import_mUSD_demo_after.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Introduces a new state migration that mutates
TokensController.allTokensacross accounts and networks, which can affect users’ token lists if edge cases were missed. Additional changes update controller event subscriptions and LavaMoat policies, so misconfiguration could cause runtime messaging or bundling issues.Overview
Adds migration
207to auto-track mUSD by default. On upgrade, it seeds the mUSD token intoTokensController.allTokensfor every EVM account on0x1,0xe708, and0x8f, preserving existing tokens and avoiding duplicates via case-insensitive address checks.Updates messenger allowlists so assets/tokens/token-detection controllers also react to
NetworkController:networkAdded(and tokens additionally toAccountsController:accountAddedandKeyringController:unlock). Tests and E2E state snapshots are adjusted to reflect seeded tokens and updated network/controller state,@metamask/assets-controllersis bumped to^105.1.0,privacy-snapshot.jsonaddsapi.merkl.xyz, and multiple LavaMoat policies are updated for revised keyring dependency paths and@metamask/messengeraccess.Reviewed by Cursor Bugbot for commit d4b8877. Bugbot is set up for automated code reviews on this repo. Configure here.