Skip to content

Patch 4.0.5#192

Merged
alina-p-k merged 7 commits intomainfrom
patch-4.0.5
Oct 22, 2025
Merged

Patch 4.0.5#192
alina-p-k merged 7 commits intomainfrom
patch-4.0.5

Conversation

@alina-p-k
Copy link
Copy Markdown
Collaborator

@alina-p-k alina-p-k commented Oct 14, 2025

feat:

  • added an ability to customize dismiss drag gesture interaction area size

fix:

  • problem with scrollview conflicts

Related issue #184

- fixed problem with scrollview conflicts
- added an ability to customize dismiss drag gesture interaction area size
@alina-p-k alina-p-k requested a review from FulcrumOne as a code owner October 14, 2025 19:02
@alina-p-k alina-p-k requested a review from Copilot October 14, 2025 19:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds drag gesture interaction area customization to address ScrollView conflicts in popup dismissal gestures and bumps version to 4.0.5.

  • Fixed ScrollView conflicts by moving drag gesture from stack level to individual popup level and changing from highPriorityGesture to simultaneousGesture
  • Added dragGestureAreaSize configuration property to control the draggable area size for dismiss gestures
  • Updated drag gesture handling to validate gesture start location against the configured area size

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Sources/Public/Setup/Public+Setup+Config.swift Added dragGestureAreaSize configuration method to global vertical config
Sources/Public/Popup/Public+Popup+Config.swift Added dragGestureAreaSize configuration method to local vertical config
Sources/Internal/View Models/ViewModel+VerticalStack.swift Updated drag gesture handling to accept full DragGesture.Value and added validation logic
Sources/Internal/UI/PopupVerticalStackView.swift Moved drag gesture from stack to individual popup level and extracted popup alignment
Sources/Internal/Models/AnyPopupConfig.swift Added dragGestureAreaSize property to popup config model
Sources/Internal/Extensions/View+Gestures.swift Changed drag gesture from high priority to simultaneous and updated parameter types
Sources/Internal/Configurables/Local/LocalConfig.swift Added dragGestureAreaSize property to local config protocol
Sources/Internal/Configurables/Local/LocalConfig+Vertical.swift Added dragGestureAreaSize property initialization for vertical config
Sources/Internal/Configurables/Local/LocalConfig+Center.swift Added dragGestureAreaSize property and reformatted class declaration
Sources/Internal/Configurables/Global/GlobalConfig+Vertical.swift Added dragGestureAreaSize property with default value of 30
Sources/Internal/Configurables/Global/GlobalConfig+Center.swift Added dragGestureAreaSize property with default value of 0

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Sources/Internal/View Models/ViewModel+VerticalStack.swift Outdated
Comment thread Sources/Public/Setup/Public+Setup+Config.swift Outdated
Comment thread Sources/Public/Popup/Public+Popup+Config.swift Outdated
@alina-p-k alina-p-k requested a review from Copilot October 14, 2025 19:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Sources/Internal/View Models/ViewModel+VerticalStack.swift Outdated
Comment thread Sources/Internal/Configurables/Local/LocalConfig+Center.swift Outdated
@alina-p-k alina-p-k requested a review from Copilot October 15, 2025 16:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Sources/Internal/Models/DragGestureState.swift
@alina-p-k alina-p-k merged commit 3aa5523 into main Oct 22, 2025
1 check passed
@alina-p-k alina-p-k deleted the patch-4.0.5 branch October 22, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants