Conversation
- fixed problem with scrollview conflicts - added an ability to customize dismiss drag gesture interaction area size
There was a problem hiding this comment.
Pull Request Overview
Adds drag gesture interaction area customization to address ScrollView conflicts in popup dismissal gestures and bumps version to 4.0.5.
- Fixed ScrollView conflicts by moving drag gesture from stack level to individual popup level and changing from
highPriorityGesturetosimultaneousGesture - Added
dragGestureAreaSizeconfiguration property to control the draggable area size for dismiss gestures - Updated drag gesture handling to validate gesture start location against the configured area size
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Public/Setup/Public+Setup+Config.swift | Added dragGestureAreaSize configuration method to global vertical config |
| Sources/Public/Popup/Public+Popup+Config.swift | Added dragGestureAreaSize configuration method to local vertical config |
| Sources/Internal/View Models/ViewModel+VerticalStack.swift | Updated drag gesture handling to accept full DragGesture.Value and added validation logic |
| Sources/Internal/UI/PopupVerticalStackView.swift | Moved drag gesture from stack to individual popup level and extracted popup alignment |
| Sources/Internal/Models/AnyPopupConfig.swift | Added dragGestureAreaSize property to popup config model |
| Sources/Internal/Extensions/View+Gestures.swift | Changed drag gesture from high priority to simultaneous and updated parameter types |
| Sources/Internal/Configurables/Local/LocalConfig.swift | Added dragGestureAreaSize property to local config protocol |
| Sources/Internal/Configurables/Local/LocalConfig+Vertical.swift | Added dragGestureAreaSize property initialization for vertical config |
| Sources/Internal/Configurables/Local/LocalConfig+Center.swift | Added dragGestureAreaSize property and reformatted class declaration |
| Sources/Internal/Configurables/Global/GlobalConfig+Vertical.swift | Added dragGestureAreaSize property with default value of 30 |
| Sources/Internal/Configurables/Global/GlobalConfig+Center.swift | Added dragGestureAreaSize property with default value of 0 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
feat:
fix:
Related issue #184