Skip to content

Refactor Message Spell so Anonymous Option Works#6057

Open
Ben10083 wants to merge 6 commits intoMonkestation:mainfrom
Ben10083:Message_Spell_WHO
Open

Refactor Message Spell so Anonymous Option Works#6057
Ben10083 wants to merge 6 commits intoMonkestation:mainfrom
Ben10083:Message_Spell_WHO

Conversation

@Ben10083
Copy link
Copy Markdown

@Ben10083 Ben10083 commented Apr 8, 2026

About The Pull Request

Message Spell code changed so it properly has the sender only be 'veiled' if they want to, if the recipient does not know them, or the recipient has high enough perception.

Why It's Good For The Game

This is intended behavior

Changelog

🆑
fix: Message spell properly reveals caster if option selected
qol: Message spell now uses TGUI
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@github-actions github-actions bot added Fix This PR is for fixing bugs Code Maintenance Fixing this mess one line at a time labels Apr 8, 2026
@realforest2001
Copy link
Copy Markdown
Collaborator

While it doesn't really change much (not asking you to change your end either, just a passing comment)
You can't send an arcyne message to someone you don't know, which makes checking if the recipient knows you a moot point as I don't think we have cases of one person knowing a target and the target not knowing them back.

@Ben10083
Copy link
Copy Markdown
Author

Ben10083 commented Apr 9, 2026

While it doesn't really change much (not asking you to change your end either, just a passing comment) You can't send an arcyne message to someone you don't know, which makes checking if the recipient knows you a moot point as I don't think we have cases of one person knowing a target and the target not knowing them back.

In retrospect yeah. I didnt want to change too much of the existing code bc I wasnt sure if there was a scenario that I wasnt thinking of. Like you said though, doesnt change anything so who cares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Maintenance Fixing this mess one line at a time Fix This PR is for fixing bugs

Projects

Status: Labeling Complete

Development

Successfully merging this pull request may close these issues.

3 participants