Move endroid/qr-code to require and exclude from app bundles#90
Merged
shanerbaner82 merged 1 commit intomainfrom Apr 10, 2026
Merged
Move endroid/qr-code to require and exclude from app bundles#90shanerbaner82 merged 1 commit intomainfrom
shanerbaner82 merged 1 commit intomainfrom
Conversation
The QR code package is needed at runtime for the Jump dev server but should not be shipped in mobile app bundles (~15MB bloat). Moves it from require-dev to require, upgrades to v6, updates the Builder API usage, and adds vendor/endroid to exclusion lists in all build paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
endroid/qr-codefromrequire-devtorequire(needed at runtime by Jump dev server for QR code generation)^6.1.3) and updatesBuilderAPI usage inrouter.phpvendor/endroidfrom all app bundle build paths to prevent ~15MB bloat:JumpCommand.php— Jump ZIP bundlePreparesBuild.php— Androidnative:run/native:packageBuildIosAppCommand.php— iOSnative:run/native:packageTest plan
native:jumpand verify QR code renders in browsernative:run androidand confirm bundle size is reducednative:run iosand confirm bundle size is reducedvendor/endroidis not present in built app bundles🤖 Generated with Claude Code