Skip to content

libafpclient: detect Windows hosts by machine name#210

Merged
rdmark merged 1 commit intomainfrom
rdmark-detect-windows
May 3, 2026
Merged

libafpclient: detect Windows hosts by machine name#210
rdmark merged 1 commit intomainfrom
rdmark-detect-windows

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Apr 26, 2026

No description provided.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Apr 26, 2026

@NJRoadfan using your research for this -- can be handy in the future to deal with Windows host quirks

@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented Apr 26, 2026

🤖 Augment PR Summary

Summary: Extends afp_server_identify() to recognize AFP servers that report a Windows-based machine_type string.
Changes: Adds a new "Windows" detection branch with debug logging and assigns a server type based on the reported platform.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestion posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

Comment thread lib/identify.c Outdated
@rdmark rdmark force-pushed the rdmark-detect-windows branch from 01f3ba5 to e4c85d3 Compare April 26, 2026 10:09
@sonarqubecloud
Copy link
Copy Markdown

@rdmark rdmark merged commit d35a122 into main May 3, 2026
18 checks passed
@rdmark rdmark deleted the rdmark-detect-windows branch May 3, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant