PROXY Protocol Round 3?#5506
Conversation
…/nginx-proxy-manager:develop into develop
…oxy-manager into develop # Conflicts: # backend/schema/endpoints/proxy-hosts.json # backend/templates/_listen.conf
Update proxy_host.js
Initial work to move prior work to new UI and API
reversefold
force-pushed
the
proxy-protocol
branch
from
1079e11 to
d9990df
Compare
|
Updated to be a real merge of the prior work instead of a rebase. |
|
I have additionally added PROXY protocol support for streams. |
|
Not sure why that build failed... |
Make the variable name a little more generic
reversefold
force-pushed
the
proxy-protocol
branch
from
6734b2b to
5965a6c
Compare
|
It looks like there's an issue with the CI not finding the en_US.UTF-8 locale. EDIT: Ah, tests failed. The jobs don't seem to flag what actually failed in an obvious way. |
|
I honestly don't know why the tests are failing, I must be missing something. The app works just fine when I actually run it and use it. |
reversefold
force-pushed
the
proxy-protocol
branch
from
cb9d5cf to
857a35e
Compare
|
All right, I've reset back to before I added the stream support. I can do that in another PR. The proxy-host stuff didn't fail tests at least. |
|
Docker Image for build 10 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
5 participants
I decided to take a look at #4505 and see what it would take to make it work. I merged adrum's branch onto develop and fixed the issues I found.
I believe this is a fully working version of the PROXY protocol support, with support for Proxy Hosts. I was able to create and edit both proxy hosts and streams in a dev environment with no issues.
I have support for PROXY protocol with streams working in local testing but it fails to pass the CI tests for reasons I don't currently understand.
Thanks to @adrum and @SBado for their prior work on this.