fix(ui): ON-5532 page freezing when language is changed#2501
Merged
fix(ui): ON-5532 page freezing when language is changed#2501
Conversation
The useEffect hooks inside of our custom useTranslation hook were causing circular state updates. The language changes without them when a different one was selected, so they weren't necessary in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The useEffect hooks inside of our custom useTranslation hook in
i18n/client.tswere causing circular state updates. The language changes without them when a different one was selected, so they weren't necessary in the first place.