[frontend] feat(iconbar): fix selected domains (#103)#5677
Merged
GaetanSantucci merged 2 commits intorelease/currentfrom May 6, 2026
Merged
[frontend] feat(iconbar): fix selected domains (#103)#5677GaetanSantucci merged 2 commits intorelease/currentfrom
GaetanSantucci merged 2 commits intorelease/currentfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the domain icon-bar filter toggle behavior so a selected domain can be deselected even when multiple domains are active (reported on the Threat Arsenal page). The change aligns the click handler with the queryable filter state by updating filter values in-place instead of using a helper that only appends values.
Changes:
- Compute next selected domains from the current
SearchPaginationInputfilter values rather than local state. - Use
handleUpdateValuesByIdto replace the filter’s values (supports removing values), and fall back to creating the filter when missing. - Minor adjustment to how
selectedDomainsis synced from the active filter.
91a255e to
04fdb05
Compare
RomuDeuxfois
approved these changes
May 5, 2026
04fdb05 to
e5359e0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/current #5677 +/- ##
=====================================================
- Coverage 40.40% 40.39% -0.01%
+ Complexity 6113 6112 -1
=====================================================
Files 2123 2123
Lines 56989 56991 +2
Branches 7229 7230 +1
=====================================================
- Hits 23025 23023 -2
- Misses 32610 32613 +3
- Partials 1354 1355 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the new Threat Arsenal page, when I select two domain filters, I can no longer deselect them by clicking on them. It only works with one domain.
Expected Output
The domain filter should deselect when I click on it if it is active, even if several domains are selected
Testing Instructions
Related issues