Skip to content

[frontend] feat(iconbar): fix selected domains (#103)#5677

Merged
GaetanSantucci merged 2 commits intorelease/currentfrom
issue/103-fix-domain-filter-selection
May 6, 2026
Merged

[frontend] feat(iconbar): fix selected domains (#103)#5677
GaetanSantucci merged 2 commits intorelease/currentfrom
issue/103-fix-domain-filter-selection

Conversation

@GaetanSantucci
Copy link
Copy Markdown
Member

Description
On the new Threat Arsenal page, when I select two domain filters, I can no longer deselect them by clicking on them. It only works with one domain.

Expected Output
The domain filter should deselect when I click on it if it is active, even if several domains are selected

Testing Instructions

  1. Test iconbar behavior to display multiple domains

Related issues

@GaetanSantucci GaetanSantucci self-assigned this May 4, 2026
@github-actions github-actions Bot added the filigran team use to identify PR from the Filigran team label May 4, 2026
@GaetanSantucci GaetanSantucci changed the title fix selected domains [frontend] fix(iconbar) : selected domains (#103) May 4, 2026
@GaetanSantucci GaetanSantucci requested a review from Copilot May 5, 2026 05:48
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the domain icon-bar filter toggle behavior so a selected domain can be deselected even when multiple domains are active (reported on the Threat Arsenal page). The change aligns the click handler with the queryable filter state by updating filter values in-place instead of using a helper that only appends values.

Changes:

  • Compute next selected domains from the current SearchPaginationInput filter values rather than local state.
  • Use handleUpdateValuesById to replace the filter’s values (supports removing values), and fall back to creating the filter when missing.
  • Minor adjustment to how selectedDomains is synced from the active filter.

@GaetanSantucci GaetanSantucci changed the title [frontend] fix(iconbar) : selected domains (#103) [frontend] fix(iconbar): selected domains (#103) May 5, 2026
@GaetanSantucci GaetanSantucci changed the title [frontend] fix(iconbar): selected domains (#103) [frontend] feat(iconbar): fix selected domains (#103) May 5, 2026
@GaetanSantucci GaetanSantucci force-pushed the issue/103-fix-domain-filter-selection branch from 91a255e to 04fdb05 Compare May 5, 2026 07:35
@GaetanSantucci GaetanSantucci force-pushed the issue/103-fix-domain-filter-selection branch from 04fdb05 to e5359e0 Compare May 6, 2026 09:15
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.39%. Comparing base (d00e1e4) to head (e5359e0).

Files with missing lines Patch % Lines
...n/components/common/domains/useDomainIconFilter.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #5677      +/-   ##
=====================================================
- Coverage              40.40%   40.39%   -0.01%     
+ Complexity              6113     6112       -1     
=====================================================
  Files                   2123     2123              
  Lines                  56989    56991       +2     
  Branches                7229     7230       +1     
=====================================================
- Hits                   23025    23023       -2     
- Misses                 32610    32613       +3     
- Partials                1354     1355       +1     
Flag Coverage Δ
backend 64.33% <ø> (-0.01%) ⬇️
frontend 1.42% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GaetanSantucci GaetanSantucci merged commit 97fb54c into release/current May 6, 2026
34 of 35 checks passed
@GaetanSantucci GaetanSantucci deleted the issue/103-fix-domain-filter-selection branch May 6, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants