Skip to content

[frontend] fix: handle payload arguments correctly in updates (#4824)#5704

Merged
savacano28 merged 5 commits intorelease/currentfrom
fix/105-internal
May 7, 2026
Merged

[frontend] fix: handle payload arguments correctly in updates (#4824)#5704
savacano28 merged 5 commits intorelease/currentfrom
fix/105-internal

Conversation

@savacano28
Copy link
Copy Markdown
Contributor

@savacano28 savacano28 commented May 6, 2026

Proposed changes

  • Fix update of payloads with arguments. This bug was introduced in chaining feature (typed arguments).

Testing Instructions

  1. Go threath arsenal page
  2. Create payload with arguments
  3. Update it
  4. Re open and check values

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this May 6, 2026
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label May 6, 2026
@savacano28 savacano28 changed the title [frontend] fix: allow update payloads withh paylaod arguments [frontend] fix: allow update payloads withh paylaod arguments (#4458) May 6, 2026
@savacano28 savacano28 changed the title [frontend] fix: allow update payloads withh paylaod arguments (#4458) [frontend] fix: update payloads with payload arguments (#4458) May 6, 2026
@savacano28 savacano28 marked this pull request as ready for review May 6, 2026 11:14
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.34%. Comparing base (e2f556c) to head (190593d).

Files with missing lines Patch % Lines
...ents/threat_arsenal/ThreatArsenalActionPopover.tsx 0.00% 14 Missing ⚠️
...ponents/threat_arsenal/ThreatArsenalActionForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #5704      +/-   ##
=====================================================
- Coverage              40.34%   40.34%   -0.01%     
  Complexity              6112     6112              
=====================================================
  Files                   2123     2123              
  Lines                  57083    57087       +4     
  Branches                7246     7249       +3     
=====================================================
  Hits                   23029    23029              
- Misses                 32700    32704       +4     
  Partials                1354     1354              
Flag Coverage Δ
backend 64.20% <ø> (ø)
frontend 1.42% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camrrx camrrx requested review from camrrx May 6, 2026 14:02
Comment thread openaev-front/src/admin/components/threat_arsenal/ThreatArsenalActionForm.tsx Outdated
@savacano28 savacano28 changed the title [frontend] fix: update payloads with payload arguments (#4458) [frontend] fix: update payloads with payload arguments (#4824) May 7, 2026
@savacano28 savacano28 changed the title [frontend] fix: update payloads with payload arguments (#4824) [frontend] fix: resolve payload argument issue in updates (#4824) May 7, 2026
@savacano28 savacano28 changed the title [frontend] fix: resolve payload argument issue in updates (#4824) [frontend] fix: resolve payload argument issue (#4824) May 7, 2026
@savacano28 savacano28 changed the title [frontend] fix: resolve payload argument issue (#4824) [frontend] fix: handle payload arguments correctly in updates (#4824) May 7, 2026
@savacano28 savacano28 merged commit 4672fb4 into release/current May 7, 2026
37 of 38 checks passed
@savacano28 savacano28 deleted the fix/105-internal branch May 7, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants