Skip to content

[frontend] fix: internal error in mitre attack widget (#5680)#5706

Merged
savacano28 merged 2 commits intomasterfrom
fix/5680
May 6, 2026
Merged

[frontend] fix: internal error in mitre attack widget (#5680)#5706
savacano28 merged 2 commits intomasterfrom
fix/5680

Conversation

@savacano28
Copy link
Copy Markdown
Contributor

@savacano28 savacano28 commented May 6, 2026

Proposed changes

  • Fix error when click on checkbox: Show covered TTP only

Testing Instructions

  1. Go to dashboard
  2. Add widget Mitre attack
  3. Check/uncheck Show covered TTP only

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@savacano28 savacano28 self-assigned this May 6, 2026
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label May 6, 2026
@savacano28 savacano28 marked this pull request as ready for review May 6, 2026 11:57
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 37.13%. Comparing base (a68c4e0) to head (62e606b).

Files with missing lines Patch % Lines
...om_dashboards/widgets/viz/KillChainPhaseColumn.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5706   +/-   ##
=========================================
  Coverage     37.12%   37.13%           
  Complexity     4923     4923           
=========================================
  Files          1881     1881           
  Lines         49402    49402           
  Branches       6143     6143           
=========================================
+ Hits          18341    18343    +2     
+ Misses        29971    29969    -2     
  Partials       1090     1090           
Flag Coverage Δ
backend 59.02% <ø> (ø)
e2e 24.89% <ø> (ø)
frontend 0.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camrrx camrrx self-requested a review May 6, 2026 13:26
Copy link
Copy Markdown
Member

@camrrx camrrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK

@savacano28 savacano28 merged commit 53a2118 into master May 6, 2026
35 of 36 checks passed
@savacano28 savacano28 deleted the fix/5680 branch May 6, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Dashboard] MITRE Coverage "Show covered TTP only" filter triggers unknown error

2 participants