Skip to content

Update to checkAppClassAndResourceAccess#34775

Open
jimblye wants to merge 1 commit intoOpenLiberty:integrationfrom
jimblye:wrong-resource-name-in-checkAppClassAndResourceAccess
Open

Update to checkAppClassAndResourceAccess#34775
jimblye wants to merge 1 commit intoOpenLiberty:integrationfrom
jimblye:wrong-resource-name-in-checkAppClassAndResourceAccess

Conversation

@jimblye
Copy link
Copy Markdown
Member

@jimblye jimblye commented Apr 29, 2026

################################################################################################

Test fix:

  • Before the fix, the negative resource requests sent resosurcename=...
  • The servlet never reads that parameter, because it only looks for "resourcename"
  • Therefore resourcename == null
  • Then the entire resource-check block is skipped:
    no getClass().getResource(...)
    no validation of expected failure
    no servlet exception if the resource is unexpectedly visible
  • The request would return successfully unless some unrelated failure occurred

@jimblye jimblye self-assigned this Apr 29, 2026
@jimblye
Copy link
Copy Markdown
Member Author

jimblye commented Apr 29, 2026

!buiild

@jimblye
Copy link
Copy Markdown
Member Author

jimblye commented Apr 30, 2026

!build (view Open Liberty Personal Build - ✅ completed successfully!)

Note: Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link
Copy Markdown
Member

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • Please describe in a separate comment how you tested your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants