FR: Optionally wait for IP addresses#190
Open
mgreter wants to merge 1 commit intoOpenRC:masterfrom
Open
Conversation
Contributor
|
@mgreter Please rebase on master and remove the code for the other pull request. Also, in the future, please avoid putting code from multiple pull requests together. Thanks, William |
314e391 to
1c30020
Compare
Contributor
Author
|
Done, rebased to latest master. And sorry, just kept it in to avoid merge conflicts! |
Contributor
|
@mgreter I like the concept, but I'm wondering if there is a more efficient way to do it that does not use head or grep. Also, you can test for the presence of the ip command with something like: if [ -n "$(command -v ip)" ]; then
# Now we know we have the ip command
fi |
Contributor
Author
|
It might be possible to use a construct like if [[ $ipaddr == *"inet"* ]]; thenWill hopefully get around to test this upcoming weekend |
1c30020 to
7d9cf6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the need to also wait until dhcp has assigned some ip addresses to the
interfaces before starting my firewall. Not sure if you want to include this, as
it needs the
ipcommand fromiproute2pkg, but I figured I'd create a PRanyway. Also included the bugfix from my other PR to avoid merge conflicts.
Thanks for consideration!