Blog Post: Advancements in Lightning Infrastructure#432
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@niftynei Would really appreciate a direct quote once you get a chance to review 🙏 |
|
@OpenSats/volunteers if you have a moment to spare, would you please do a quick sanity check on the writeup? 🙏 |
|
@Arvin21M Many thanks, looking great! A couple of tweaks from our end:
|
|
@DanielFeichtinger |
vincenzopalazzo
left a comment
There was a problem hiding this comment.
Sorry to be late to the party, I left some comments.
Overall LGTM :)
Co-authored-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Co-authored-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
optout21
left a comment
There was a problem hiding this comment.
From Splicing/Optout part, I would suggest 3 minor edits -- see them commented inline.
- The paragraph "This work has required ... interrupting active transactions" should be dropped altogether, as it contains minute details that don't add much info in this context.
- In the following paragraph, some small changes:
- Remove
ldk-nodefrom the list - Rephrase next sentence to "Although several foundational pull requests have been
merged, further work is needed to finalize integration into LDK and
ensure interoperability before Splicing is fully production-ready within LDK."
Otherwise good job, thank you gentlemen!
Co-authored-by: optout <13562139+optout21@users.noreply.github.com>
Arvin21M
left a comment
There was a problem hiding this comment.
- The review process for this draft by the grantees with their respective projects included in this draft (via change requests, or go-ahead with no change requests) appears to be complete at this point.
- One final review by OS board member and adding quote in opening section are the final steps.
- Thanks to everyone who spent time reviewing.
🙏
There was a problem hiding this comment.
Read this quickly. One nit that came to mind: variants of "enabl(e|ed|ing)" are used 11 times and "leverag(e|ing)" 3 times. To my mind, these are MBA consultant-style words that are easy to overuse. Feel free to ignore!
Edit: otherwise looks great!
|
Update commit a596508 looks good 👍 |
dergigi
left a comment
There was a problem hiding this comment.
Looks good to me!
Thanks everyone for helping to get this out the door. 🙏 --- ![]()
Build Preview:
Header Image: