Merged
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
paul0403
approved these changes
Apr 17, 2026
dwierichs
requested changes
Apr 17, 2026
Contributor
dwierichs
left a comment
dwierichs
left a comment
There was a problem hiding this comment.
LGTM, does it make sense to add a test?
Please add a changelog as well :)
Member
Author
Sure, they are updated in this commit: 91419e4 |
Member
|
Catalyst wheels is currently blocked by something unrelated, let;s wait until that is resolved, so we can publish new catalyst wheels, and this PR can track that new catalyst version. |
dwierichs
approved these changes
Apr 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9328 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 610 610
Lines 66809 66809
=======================================
+ Hits 66436 66437 +1
+ Misses 373 372 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
rniczh
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Apr 23, 2026
**Context:** Due to the circular dependency between Pennylane and Catalyst, we added xfails on `fixed work wire type`'s tests to merge the following two PRs. Now, both PRs have been merged, we're good to remove these XFails from our tests. PennyLaneAI/pennylane#9328 #2710 **Description of the Change:** Remove xfails **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-116955] [sc-116989]
mudit2812
pushed a commit
that referenced
this pull request
Apr 28, 2026
**Context:** The `work_wire_type` is missing for the path (compiler activate) that passing to the `catalyst.ctrl`. **Description of the Change:** Add the parameter. And it requires the corresponding change added to catalyst. PennyLaneAI/catalyst#2710 **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-116955] [sc-116989]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
The
work_wire_typeis missing for the path (compiler activate) that passing to thecatalyst.ctrl.Description of the Change:
Add the parameter.
And it requires the corresponding change added to catalyst.
PennyLaneAI/catalyst#2710
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-116955]
[sc-116989]