chore: remove unused decide helper and stale references#503
Open
marandaneto wants to merge 2 commits intomasterfrom
Open
chore: remove unused decide helper and stale references#503marandaneto wants to merge 2 commits intomasterfrom
marandaneto wants to merge 2 commits intomasterfrom
Conversation
marandaneto
commented
Apr 13, 2026
| raise APIError(res.status_code, res.text, retry_after=retry_after) | ||
|
|
||
|
|
||
| def decide( |
Member
Author
There was a problem hiding this comment.
this wasnt being called anywhere anymore so i assume its left over?
Member
Author
There was a problem hiding this comment.
@PostHog/team-feature-flags can you confirm before i pull the plug?
Contributor
|
Reviews (1): Last reviewed commit: "chore: remove unused decide helper and s..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-04-13 10:39:10 UTC ✅ All Tests Passed!29/29 tests passed Capture Tests✅ 29/29 tests passed View Details
|
dustinbyrne
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Python SDK no longer uses the legacy
/decidehelper for feature flag evaluation, but a dead helper and several stale comments/docstrings still referred to it. This made the code and tests misleading.Changes
decide()helper fromposthog/request.py/flagsflags()instead of the removed helper/decidecomments and fixture values in feature flag tests where they now describe/flagsfallbackposthog/test/test_request.pywith RuffChecklist
uv run pytest posthog/test/test_request.py posthog/test/test_types.py -q,uv run pytest posthog/test/test_feature_flags.py -q, anduvx ruff format --check .)