Show read-only popups on GeoJSON pages by default#855
Closed
JeroenDeDauw wants to merge 2 commits into
Closed
Conversation
Previously, users with edit permissions would immediately see editable textareas in GeoJSON map popups, even when just viewing the page. This was confusing since the UI appeared editable in read mode. Now the map always starts in view-only mode with plain text popups. Users with edit permissions see a pencil button on the map that switches to the full editor with draw controls and editable popups when clicked. Closes #738 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Starting in edit mode is nice though, so this is not a good solution |
Previously, clicking a marker on a GeoJSON page immediately showed editable textareas and a save button, which was confusing in read mode. Now popups show read-only text content by default, with an "Edit" link that switches to the textarea editing interface. The editor with draw controls still starts immediately for users with edit permissions, preserving the existing workflow. Closes #738 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
Claude: Thanks for the feedback! I've revised the approach: the editor still starts immediately (draw controls available right away), but the marker popups now show read-only text by default with an "Edit" link. Clicking the link switches the popup to the textarea editing interface. This way the editing workflow is preserved while the popups no longer look confusingly editable in read mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LeafletEditor.jsonly — the_onEditableFeaturepopup now has a read view and an edit viewCloses #738
Test plan
🤖 Generated with Claude Code