Skip to content

Fix Google Maps removeLine/removePolygon crash #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeroenDeDauw merged 1 commit into from
Apr 6, 2026
Merged

Fix Google Maps removeLine/removePolygon crash #885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 10 additions & 16 deletions resources/GoogleMaps/jquery.googlemap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,10 @@

for (var i = this.markers.length - 1; i >= 0; i--) {
if (this.markers[i] === marker) {
delete this.markers[i];
this.markers.splice(i, 1);
break;
}
}

delete marker;
};

/**
Expand Down Expand Up @@ -274,14 +272,12 @@
this.removeLine = function (line) {
line.setMap(null);

for (var i = this.line.length - 1; i >= 0; i--) {
if (this.line[i] === line) {
delete this.line[i];
for (var i = this.lines.length - 1; i >= 0; i--) {
if (this.lines[i] === line) {
this.lines.splice(i, 1);
break;
}
}

delete line;
};

this.removeLines = function () {
Expand Down Expand Up @@ -401,21 +397,19 @@
this.removePolygon = function (polygon) {
polygon.setMap(null);

for (var i = this.polygon.length - 1; i >= 0; i--) {
if (this.polygon[i] === polygon) {
delete this.polygon[i];
for (var i = this.polygons.length - 1; i >= 0; i--) {
if (this.polygons[i] === polygon) {
this.polygons.splice(i, 1);
break;
}
}

delete polygon;
};

this.removePolygons = function () {
for (var i = this.polygon.length - 1; i >= 0; i--) {
this.polygon[i].setMap(null);
for (var i = this.polygons.length - 1; i >= 0; i--) {
this.polygons[i].setMap(null);
}
this.polygon = [];
this.polygons = [];
};

//Rezoom's the map to show all visible markers.
Expand Down
Loading