Use cgi/escape for Ruby 4.0 compatibility#785
Open
joshwetzel wants to merge 1 commit intoSAML-Toolkits:masterfrom
Open
Use cgi/escape for Ruby 4.0 compatibility#785joshwetzel wants to merge 1 commit intoSAML-Toolkits:masterfrom
joshwetzel wants to merge 1 commit intoSAML-Toolkits:masterfrom
Conversation
Contributor
Author
Collaborator
|
@pitbulk can we release RubySaml 2.0 -- I already fixed this there, along with many other bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 4.0 removed the full CGI library from the standard library, which produces a warning. Since the code only uses
CGI.escape, we can requirecgi/escapeinstead of the fullcgilibrary. This provides just the escape/unescape functionality and is compatible with both Ruby 3.x and 4.x.