openjdk19: fix checkver for archived release line#593
openjdk19: fix checkver for archived release line#593B67687 wants to merge 2 commits intoScoopInstaller:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/openjdk19.json`:
- Around line 17-21: The autoupdate block references placeholders ($matchType,
$matchPath, $matchFile) that are no longer produced by checkver.regex (which
only defines named groups version and build), so either remove or disable the
autoupdate section or update it to use the new named groups (or add capturing
groups named matchType/matchPath/matchFile) so placeholders in
autoupdate.architecture.64bit.url resolve properly; locate checkver.regex and
autoupdate.architecture.64bit.url in openjdk19.json and choose one fix: delete
the dormant autoupdate, adapt its placeholders to use ${version}/${build}, or
extend the regex to expose the original matchType/matchPath/matchFile names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 327ee9d7-e2d0-4d3e-b701-58a08d8c3fd7
📒 Files selected for processing (1)
bucket/openjdk19.json
✅ Actions performedReview triggered.
|
2 similar comments
✅ Actions performedReview triggered.
|
✅ Actions performedReview triggered.
|
Summary
openjdk19checkverby switching it from the supersededjdk.java.net/19page to the officialopenjdk/jdk19utags APIopenjdk18out of scope for now because it needs separate handlingWhy this changed
https://jdk.java.net/19is now a superseded landing page, so the old page-scraping regex no longer detects the final19.0.2-7release correctly.For
openjdk19, the officialopenjdk/jdk19utags still expose the exact archived line the manifest points to, includingjdk-19.0.2+7, so this restorescheckverwithout changing the binary source.I left
openjdk18out of this follow-up on purpose. Its current manifest version is still18.0.2.1-1, but the upstream source/tag story there is less straightforward than19, so I did not want to overclaim the scope here.Verification
checkver.ps1 openjdk19->19.0.2-7checkurls.ps1 -App openjdk19->[1][1][0]200 OKSummary by CodeRabbit
${version}-${build}format.