Skip to content

openjdk19: fix checkver for archived release line#593

Open
B67687 wants to merge 2 commits intoScoopInstaller:masterfrom
B67687:openjdk19-checkver-tags
Open

openjdk19: fix checkver for archived release line#593
B67687 wants to merge 2 commits intoScoopInstaller:masterfrom
B67687:openjdk19-checkver-tags

Conversation

@B67687
Copy link
Copy Markdown
Contributor

@B67687 B67687 commented Apr 24, 2026

Summary

  • fix openjdk19 checkver by switching it from the superseded jdk.java.net/19 page to the official openjdk/jdk19u tags API
  • keep the current download URL and hash unchanged, since the archived JDK 19 binary still resolves correctly
  • keep openjdk18 out of scope for now because it needs separate handling

Why this changed

https://jdk.java.net/19 is now a superseded landing page, so the old page-scraping regex no longer detects the final 19.0.2-7 release correctly.

For openjdk19, the official openjdk/jdk19u tags still expose the exact archived line the manifest points to, including jdk-19.0.2+7, so this restores checkver without changing the binary source.

I left openjdk18 out of this follow-up on purpose. Its current manifest version is still 18.0.2.1-1, but the upstream source/tag story there is less straightforward than 19, so I did not want to overclaim the scope here.

Verification

  • checkver.ps1 openjdk19 -> 19.0.2-7
  • checkurls.ps1 -App openjdk19 -> [1][1][0]
  • confirmed the existing archived binary URL still returns 200 OK

Summary by CodeRabbit

  • Bug Fixes
    • Improved OpenJDK 19 version detection for greater accuracy.
    • Version strings now use a simplified ${version}-${build} format.
    • Removed previous auto-update download mapping logic to streamline update handling.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07b6b492-e6c4-46d1-90c6-98ab47170afc

📥 Commits

Reviewing files that changed from the base of the PR and between 9bb4512 and d708478.

📒 Files selected for processing (1)
  • bucket/openjdk19.json

Walkthrough

The checkver configuration in the OpenJDK19 package definition now queries the jdk19u GitHub repository tags via the GitHub API to extract version and build from tag names (jdk-19.x+y) and formats the version as ${version}-${build}; the previous autoupdate section was removed.

Changes

Cohort / File(s) Summary
OpenJDK Version Check Configuration
bucket/openjdk19.json
Replaced download-page URL parsing with GitHub API tag queries in checkver; regex now extracts version and build from jdk-19.x+y tag names and outputs ${version}-${build}. Removed the prior autoupdate block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

review-needed

Suggested reviewers

  • chawyehsu

Poem

🐰 I hopped to GitHub, tags in sight,
From downloads old to tags so bright.
Version and build, a tidy pair,
I format, fetch, and nibble care. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the checkver for openjdk19's archived release line.
Description check ✅ Passed The description includes all required template sections: Contributing Guide acknowledgment, summary of changes, rationale, and verification results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/openjdk19.json`:
- Around line 17-21: The autoupdate block references placeholders ($matchType,
$matchPath, $matchFile) that are no longer produced by checkver.regex (which
only defines named groups version and build), so either remove or disable the
autoupdate section or update it to use the new named groups (or add capturing
groups named matchType/matchPath/matchFile) so placeholders in
autoupdate.architecture.64bit.url resolve properly; locate checkver.regex and
autoupdate.architecture.64bit.url in openjdk19.json and choose one fix: delete
the dormant autoupdate, adapt its placeholders to use ${version}/${build}, or
extend the regex to expose the original matchType/matchPath/matchFile names.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 327ee9d7-e2d0-4d3e-b701-58a08d8c3fd7

📥 Commits

Reviewing files that changed from the base of the PR and between aded4b6 and 9bb4512.

📒 Files selected for processing (1)
  • bucket/openjdk19.json

Comment thread bucket/openjdk19.json Outdated
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

2 similar comments
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant