fix: updates test to mock the getPackageManager call#3745
Open
fix: updates test to mock the getPackageManager call#3745
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
Contributor
|
We detected some changes in |
fredericoo
approved these changes
Apr 24, 2026
Contributor
fredericoo
left a comment
There was a problem hiding this comment.
lgtm, thanks for the fix
one nit below
Co-authored-by: ✦ freddie <45042736+fredericoo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Two tests in
upgrade.test.ts(should allow --version=next in tests and CI environmentsandshould complete full upgrade flow with --version=next) fail in CLI becausegetPackageManagershells out tonpm prefix, which is rejected now with "npm is no longer supported in a global context."WHAT is this pull request doing?
Mocks
getPackageManagerfrom@shopify/cli-kit/node/node-package-managerin the upgrade test file. This prevents the test from spawning a realnpmsubprocess duringdisplayUpgradeSummary. The mock usesvi.importActualto preserve all other real exports (like thePackageJsontype) while only replacing the one function that shells out.No production code is changed — the fix is test-only.
HOW to test your changes?
pnpm --filter @shopify/cli-hydrogen run test -- upgrade.test.tsAll 71 tests should pass, including the two that previously failed:
Checklist