Draft
Conversation
mrousavy
reviewed
Apr 21, 2026
Comment on lines
+829
to
+871
| } else if (type == "skFill") { | ||
| drawPaint(); | ||
| } else if (type == "skImage") { | ||
| drawImage(runtime, props); | ||
| } else if (type == "skCircle") { | ||
| drawCircle(runtime, props); | ||
| } else if (type == "skPoints") { | ||
| drawPoints(runtime, props); | ||
| } else if (type == "skPath") { | ||
| drawPath(runtime, props); | ||
| } else if (type == "skRect") { | ||
| drawRect(runtime, props); | ||
| } else if (type == "skRRect") { | ||
| drawRRect(runtime, props); | ||
| } else if (type == "skOval") { | ||
| drawOval(runtime, props); | ||
| } else if (type == "skLine") { | ||
| drawLine(runtime, props); | ||
| } else if (type == "skPatch") { | ||
| drawPatch(runtime, props); | ||
| } else if (type == "skVertices") { | ||
| drawVertices(runtime, props); | ||
| } else if (type == "skDiffRect") { | ||
| drawDiffRect(runtime, props); | ||
| } else if (type == "skText") { | ||
| drawText(runtime, props); | ||
| } else if (type == "skTextPath") { | ||
| drawTextPath(runtime, props); | ||
| } else if (type == "skTextBlob") { | ||
| drawTextBlob(runtime, props); | ||
| } else if (type == "skGlyphs") { | ||
| drawGlyphs(runtime, props); | ||
| } else if (type == "skPicture") { | ||
| drawPicture(runtime, props); | ||
| } else if (type == "skImageSVG") { | ||
| drawImageSVG(runtime, props); | ||
| } else if (type == "skParagraph") { | ||
| drawParagraph(runtime, props); | ||
| } else if (type == "skSkottie") { | ||
| drawSkottie(runtime, props); | ||
| } else if (type == "skAtlas") { | ||
| drawAtlas(runtime, props); | ||
| } |
Contributor
There was a problem hiding this comment.
In Nitro I have a constexpr hashing creator func so that I can generate switch cases / jump tables for this, instead of walking the entire string to compare it for each if branch.
Maybe we can re-use that here, or migrate to Nitro 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.